[3.10] bpo-44640: Improve punctuation consistency in isinstance/issubclass error messages (GH-27144) #28436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pablogsal merged 1 commit into python:3.10 from miss-islington:backport-f481338-3.10

Sep 19, 2021

Contributor

miss-islington commented Sep 17, 2021 •

edited by bedevere-bot

Loading

Co-authored-by: Łukasz Langa lukasz@langa.pl
(cherry picked from commit f481338)

Co-authored-by: wyz23x2 52805709+wyz23x2@users.noreply.github.com

https://bugs.python.org/issue44640


          bpo-44640: Improve punctuation consistency in isinstance/issubclass e…

c05f05c

…rror messages (pythonGH-27144)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit f481338)

Co-authored-by: wyz23x2 <52805709+wyz23x2@users.noreply.github.com>

the-knights-who-say-ni added the CLA signed label

Contributor Author

miss-islington commented Sep 17, 2021

@wyz23x2 and @ambv: Status check is done, and it's a success ✅ .

bedevere-bot mentioned this pull request

bpo-44640: Improve punctuation in isinstance() error message #27144

Merged

Contributor Author

miss-islington commented Sep 17, 2021

@wyz23x2 and @ambv: Status check is done, and it's a success ✅ .

bedevere-bot added skip news awaiting review labels

Contributor Author

miss-islington commented Sep 17, 2021

@wyz23x2 and @ambv: Status check is done, and it's a success ✅ .

1 similar comment

Contributor Author

miss-islington commented Sep 17, 2021

@wyz23x2 and @ambv: Status check is done, and it's a success ✅ .

Contributor

ambv commented Sep 17, 2021

@pablogsal, this should either go to 3.10.0 or not to 3.10 at all. This is punctuation consistency in isinstance/issubclass

ambv assigned pablogsal

Contributor Author

miss-islington commented Sep 17, 2021

@wyz23x2 and @ambv: Status check is done, and it's a success ✅ .

pablogsal merged commit 9c23a1e into python:3.10

bedevere-bot removed the awaiting review label

miss-islington deleted the backport-f481338-3.10 branch

September 19, 2021 19:11

Member

pablogsal commented Sep 19, 2021

I am backporting this to 3.10.0

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request


          bpo-44640: Improve punctuation consistency in isinstance/issubclass e…

39c4fe5

…rror messages (pythonGH-27144) (pythonGH-28436)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit f481338)

Co-authored-by: wyz23x2 <52805709+wyz23x2@users.noreply.github.com>

Co-authored-by: wyz23x2 <52805709+wyz23x2@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels