Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45020: Freeze os, site, and codecs. #28398

Merged
merged 6 commits into from Sep 17, 2021
Merged

bpo-45020: Freeze os, site, and codecs. #28398

merged 6 commits into from Sep 17, 2021

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Sep 16, 2021 •
edited

After this, the only modules left that are imported during startup are "encodings.*". We'll tackle that after we make the build output (stdout) less noisy.

https://bugs.python.org/issue45020

@ericsnowcurrently ericsnowcurrently requested a review from a team as a code owner Sep 16, 2021
@ericsnowcurrently ericsnowcurrently mentioned this pull request Sep 16, 2021
Closed
46 tasks
gvanrossum
gvanrossum reviewed Sep 16, 2021
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Can you leave the encodings package for another time? I find the noise caused by the generation of the 120+ files there very distracting: even though they are not in the repo, the Make output still adds 360+ lines each time a dependency of _freeze_module changes, which is pretty much any C or .h file in the project.

It would be nice if we could freeze submodules of a package (and maybe even its __init__.py file) without freezing the entire package. Perhaps we can think of ways to tweak import.c so that importing "foo.bar" first looks for a frozen foo.bar before looking in foo.__path_rozen_?

PS. The default is still "off" right? I only get frozen modules with -X frozen_modules.

@ericsnowcurrently
Copy link
Member Author

ericsnowcurrently commented Sep 17, 2021 •
edited

Can you leave the encodings package for another time?

Fine with me. I'm going to run the buildbots on the PR first though.

I find the noise caused by the generation of the 120+ files there very distracting: even though they are not in the repo, the Make output still adds 360+ lines each time a dependency of _freeze_module changes, which is pretty much any C or .h file in the project.

This seems like something we could fix.

It would be nice if we could freeze submodules of a package (and maybe even its __init__.py file) without freezing the entire package. Perhaps we can think of ways to tweak import.c so that importing "foo.bar" first looks for a frozen foo.bar before looking in foo.__path_rozen_?

I have a different branch that does the right thing for __path__. I just haven't bothered with it yet.

PS. The default is still "off" right? I only get frozen modules with -X frozen_modules.

Right.

@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 17, 2021
@bedevere-bot
Copy link

bedevere-bot commented Sep 17, 2021

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 74e292182cfcc8b3413745ddbc543d7a2413b418 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 17, 2021
@ericsnowcurrently
Copy link
Member Author

ericsnowcurrently commented Sep 17, 2021 •
edited

FYI, I'm working on fixing the "altered the execution environment" (test_socket) failures I'm seeing on the refleak buildbots.

[UPDATE] Ah, looks like it wasn't me: https://bugs.python.org/issue45187#msg402074

@ericsnowcurrently ericsnowcurrently force-pushed the frozen-startup-modules-remainder branch from d7f2b64 to 80777a9 Compare Sep 17, 2021
@ericsnowcurrently ericsnowcurrently changed the title bpo-45020: Freeze the remaining stdlib modules imported during startup. bpo-45020: Freeze os, site, and codecs. Sep 17, 2021
@ericsnowcurrently ericsnowcurrently merged commit 0905916 into python:main Sep 17, 2021
11 checks passed
@ericsnowcurrently ericsnowcurrently deleted the frozen-startup-modules-remainder branch Sep 17, 2021
nsait-linaro pushed a commit to nsait-linaro/cpython that referenced this pull request Sep 21, 2021
@ericsnowcurrently @nsait-linaro
bpo-45020: Freeze os, site, and codecs. (pythongh-28398)
5544d84 
https://bugs.python.org/issue45020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

@python/windows-team windows-team

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericsnowcurrently @bedevere-bot @gvanrossum @the-knights-who-say-ni