Skip to content

/ LightTable

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small UI tweaks - font-family and placeholder text #2336

Open
pedrorgirardi opened this issue Apr 24, 2017 · 3 comments
Open

Small UI tweaks - font-family and placeholder text #2336

pedrorgirardi opened this issue Apr 24, 2017 · 3 comments
Labels
enhancement good first issue UI

Comments

@pedrorgirardi
Copy link

@pedrorgirardi pedrorgirardi commented Apr 24, 2017

I noticed that the find bar and the command palette search text looks different from the other parts of LT:

find bar

screen shot 2017-04-24 at 16 12 35

command palette

screen shot 2017-04-24 at 16 16 43

LT uses Verdana, if Verdana is "applied" it would look like:

find bar

screen shot 2017-04-24 at 16 14 12

or (with the first letter capitalized)

screen shot 2017-04-24 at 16 14 48

command palette

screen shot 2017-04-24 at 16 14 56

or (with the first letter capitalized)

screen shot 2017-04-24 at 16 15 18

Is that intentional or a "mistake"? It it's not intentional I can create a PR with the CSS changes - if that's okay for you.

Thanks guys!
@sbauer322
Copy link
Contributor

@sbauer322 sbauer322 commented Apr 25, 2017 •
edited

I'm not aware of this difference being intentional, but I would be open to a pull request correcting both the font and capitalization. I believe the first letter should be capitalized as it is consistent with other parts of LT.

Thanks for noticing this!

@pedrorgirardi
Copy link
Author

@pedrorgirardi pedrorgirardi commented Apr 25, 2017

Cool! I will submit a PR then.

Thanks, @sbauer322!

@denis631 denis631 mentioned this issue May 30, 2018
Open
@denis631
Copy link

@denis631 denis631 commented May 30, 2018

Finally made a PR for this. This was annoying me for a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue UI
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@pedrorgirardi @sbauer322 @denis631