Skip to content

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45116: Py_DEBUG ignores Py_ALWAYS_INLINE #28419

Merged
merged 1 commit into from Sep 17, 2021
Merged

bpo-45116: Py_DEBUG ignores Py_ALWAYS_INLINE #28419

merged 1 commit into from Sep 17, 2021
+13 −1

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Sep 17, 2021 •
edited by bedevere-bot

If the Py_DEBUG macro is defined, the Py_ALWAYS_INLINE macro does
nothing.

https://bugs.python.org/issue45116
@vstinner
bpo-45116: Py_DEBUG ignores Py_ALWAYS_INLINE
05e7f09 
If the Py_DEBUG macro is defined, the Py_ALWAYS_INLINE macro does
nothing.
@vstinner
Copy link
Member Author

@vstinner vstinner commented Sep 17, 2021

Tests / Address sanitizer (pull_request) Failing after 50m — Address sanitizer

It failed with a timeout:

test_error_on_stdio_flush_1 (test.test_multiprocessing_fork.WithProcessesTestProcess) ... Timeout (0:20:00)!

@vstinner
Copy link
Member Author

@vstinner vstinner commented Sep 17, 2021

Tests / Address sanitizer (pull_request) failed again :-(

test_get (test.test_multiprocessing_fork.WithProcessesTestQueue) ... Timeout (0:20:00)!
Thread 0x00007f732679bbc0 (most recent call first):
  File "/home/runner/work/cpython/cpython/Lib/multiprocessing/synchronize.py", line 261 in wait
  File "/home/runner/work/cpython/cpython/Lib/multiprocessing/synchronize.py", line 349 in wait
  File "/home/runner/work/cpython/cpython/Lib/test/_test_multiprocessing.py", line 1001 in test_get

@vstinner
Copy link
Member Author

@vstinner vstinner commented Sep 17, 2021

test_get (test.test_multiprocessing_fork.WithProcessesTestQueue) ... Timeout (0:20:00)!

This issue is tracked by: https://bugs.python.org/issue45200

@vstinner vstinner merged commit e4044e9 into python:main Sep 17, 2021
12 checks passed
@vstinner vstinner deleted the always_inline_debug branch Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot