Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45280: Add test for empty NamedTuple in test_typing #28559

Merged
merged 3 commits into from Sep 26, 2021
Merged

bpo-45280: Add test for empty NamedTuple in test_typing #28559

merged 3 commits into from Sep 26, 2021

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 25, 2021 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 25, 2021
@sobolevn @corona10
Update Misc/NEWS.d/next/Tests/2021-09-25-11-05-31.bpo-45280.3MA6lC.rst
4f28f82 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@ambv ambv changed the title bpo-45280: adds test for empty NamedTuple in test_typing bpo-45280: Add test for empty NamedTuple in test_typing Sep 26, 2021
@ambv ambv merged commit f56268a into python:main Sep 26, 2021
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 26, 2021

Thanks @sobolevn for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 26, 2021

Thanks @sobolevn for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 26, 2021

GH-28570 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

bedevere-bot commented Sep 26, 2021

GH-28571 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2021
@sobolevn @miss-islington
bpo-45280: Add test for empty NamedTuple in test_typing (pythonGH…
8cc9954 
…-28559)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit f56268a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2021
@sobolevn @miss-islington
bpo-45280: Add test for empty NamedTuple in test_typing (pythonGH…
7956403 
…-28559)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit f56268a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ambv pushed a commit that referenced this pull request Sep 26, 2021
@miss-islington @sobolevn
bpo-45280: Add test for empty NamedTuple in test_typing (GH-28559) (
08e387a 
GH-28570)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit f56268a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ambv pushed a commit that referenced this pull request Sep 26, 2021
@miss-islington @sobolevn
bpo-45280: Add test for empty NamedTuple in test_typing (GH-28559) (
d452b29 
GH-28571)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit f56268a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

@corona10 corona10

@Fidget-Spinner Fidget-Spinner

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sobolevn @miss-islington @bedevere-bot @gvanrossum @corona10 @ambv @the-knights-who-say-ni