-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-45258: search for -isysroot in addition to --sysroot #28501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
-isysroot is for macOS, while --sysroot is for gcc/linux
Is this change really needed? That code path seems to be only used in the cross-compiling case which we don't really support for macOS. And we already handle SDK paths for macOS builds in another way: see is_macosx_sdk_path(). |
Hi @ned-deily. Thanks for the review.
Sure, but there are 2 use cases I have in packaging python for conda-forge.
|
This PR is stale because it has been open for 30 days with no activity. |
@ronaldoussoren would you be able to take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimal change.
That PR is no longer relevant for "main" as setup.py has been removed there. |
This seems to rely on an implementation detail in the build system, and is IMHO not something we should actively support in this way. If this is useful it should be an explicit configure option.
|
|
-isysroot is for macOS, while --sysroot is for gcc/linux
https://bugs.python.org/issue45258