Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE fixup cython linting #42142

Merged
merged 5 commits into from Aug 8, 2021
Merged

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jun 20, 2021

the alias means you can run pre-commit run flake8-cython --all-files

flake8/cython.cfg Outdated Show resolved Hide resolved
flake8/cython.cfg Outdated Show resolved Hide resolved
@jreback
Copy link
Contributor

@jreback jreback commented Jul 4, 2021

can you merge master

@mroeschke mroeschke added this to the 1.4 milestone Jul 11, 2021
@@ -2109,7 +2109,7 @@ cpdef bint is_interval_array(ndarray values):
if not (
util.is_float_object(val.left)
or util.is_integer_object(val.left)
Copy link
Member

@jbrockmendel jbrockmendel Jul 26, 2021

i think dedent these?

# is in NA values
if kh_get_str_starts_item(na_hashset, word):
Copy link
Member

@jbrockmendel jbrockmendel Jul 26, 2021

the linter wants comments before the if?

Copy link
Member Author

@MarcoGorelli MarcoGorelli Aug 8, 2021

or just an indented comment - I've gone with that, thanks

@jreback jreback merged commit cda37fb into pandas-dev:master Aug 8, 2021
25 checks passed
@jreback
Copy link
Contributor

@jreback jreback commented Aug 8, 2021

thanks @MarcoGorelli very nice!

@MarcoGorelli MarcoGorelli deleted the fixup-cython-linting branch Aug 9, 2021
Joeperdefloep added a commit to Joeperdefloep/pandas that referenced this issue Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants