STYLE fixup cython linting #42142
Merged
STYLE fixup cython linting #42142
Conversation
jbrockmendel
reviewed
Jun 20, 2021
MarcoGorelli
reviewed
Jun 20, 2021
can you merge master |
mroeschke
approved these changes
Jul 11, 2021
jbrockmendel
reviewed
Jul 26, 2021
pandas/_libs/lib.pyx
Outdated
@@ -2109,7 +2109,7 @@ cpdef bint is_interval_array(ndarray values): | |||
if not ( | |||
util.is_float_object(val.left) | |||
or util.is_integer_object(val.left) |
i think dedent these?
jbrockmendel
reviewed
Jul 26, 2021
# is in NA values | ||
if kh_get_str_starts_item(na_hashset, word): |
the linter wants comments before the if
?
or just an indented comment - I've gone with that, thanks
thanks @MarcoGorelli very nice! |
Joeperdefloep
added a commit
to Joeperdefloep/pandas
that referenced
this issue
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
the alias means you can run
pre-commit run flake8-cython --all-files
The text was updated successfully, but these errors were encountered: