Skip to content

/ symfony Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Messenger] Allow using user's serializer for message do not fit the expected JSON structure #42257

Merged
merged 1 commit into from Sep 27, 2021
Merged

[Messenger] Allow using user's serializer for message do not fit the expected JSON structure #42257

merged 1 commit into from Sep 27, 2021

Conversation

@welcoMattic
Copy link
Contributor

@welcoMattic welcoMattic commented Jul 26, 2021 •
edited

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42072
License MIT
Doc PR symfony/symfony-docs#...

It allows user to use their own serializer to decode messages that do not fit the expected JSON structure ({ "message": { "body": "", "headers": {} } }).

Once this PR will be ok, I'll report the fix in Beanstalkd, SQS, and Doctrine Transports
@welcoMattic welcoMattic requested a review from sroze as a code owner Jul 26, 2021
@carsonbot carsonbot added this to the 5.3 milestone Jul 26, 2021
@welcoMattic welcoMattic force-pushed the redis-external-msg branch from 4dc95de to 1c18c3e Jul 26, 2021
@welcoMattic welcoMattic force-pushed the redis-external-msg branch 9 times, most recently from 93bfcd4 to 536e759 Jul 27, 2021
@welcoMattic
Copy link
Contributor Author

@welcoMattic welcoMattic commented Jul 27, 2021 •
edited

@carsonbot find me a reviewer please (I'm discovering that Carson can do more things than automate status in reaction to git actions 😄 )

@carsonbot
Copy link

@carsonbot carsonbot commented Jul 27, 2021

@jonashrem could maybe review this PR?

@welcoMattic welcoMattic force-pushed the redis-external-msg branch from 0ad7c4f to 5db2ba1 Jul 27, 2021
@welcoMattic welcoMattic force-pushed the redis-external-msg branch 6 times, most recently from 80be65a to d529c6b Jul 27, 2021
@welcoMattic
Copy link
Contributor Author

@welcoMattic welcoMattic commented Jul 28, 2021

Status: Needs review

@carsonbot carsonbot changed the title Allow using user's serializer for message do not fit the expected JSON structure [Messenger] Allow using user's serializer for message do not fit the expected JSON structure Jul 30, 2021
@lyrixx lyrixx removed this from the 5.3 milestone Sep 13, 2021
@lyrixx lyrixx added this to the 5.4 milestone Sep 13, 2021
@welcoMattic welcoMattic force-pushed the redis-external-msg branch from d529c6b to 4b880af Sep 14, 2021
@welcoMattic
Copy link
Contributor Author

@welcoMattic welcoMattic commented Sep 14, 2021

This PR is ready to be reviewed

lyrixx
lyrixx approved these changes Sep 14, 2021
View changes
Copy link
Member

@lyrixx lyrixx left a comment

Looks good to me but I didn't test it

fabpot
fabpot approved these changes Sep 27, 2021
View changes
@welcoMattic @fabpot
Allow using user's serializer for message do not fit the expected JSO…
3d0d8a3 
…N structure
@fabpot fabpot changed the base branch from 5.3 to 5.4 Sep 27, 2021
@fabpot
Copy link
Member

@fabpot fabpot commented Sep 27, 2021

Merging in 5.4 as this is a new feature.

@fabpot fabpot force-pushed the redis-external-msg branch from 4b880af to 3d0d8a3 Sep 27, 2021
@fabpot
Copy link
Member

@fabpot fabpot commented Sep 27, 2021

Thank you @welcoMattic.

@fabpot fabpot merged commit d1fd413 into symfony:5.4 Sep 27, 2021
0 of 2 checks passed
@fabpot fabpot mentioned this pull request Sep 27, 2021
Open
@welcoMattic welcoMattic deleted the redis-external-msg branch Sep 27, 2021
@alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Sep 27, 2021

@welcoMattic Good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot

@lyrixx lyrixx

@alexander-schranz alexander-schranz

@chalasr chalasr

@sroze sroze

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
5.4
Linked issues

Successfully merging this pull request may close these issues.

[Messenger] [Redis] Can not consume messages published by third party in Redis
6 participants
@welcoMattic @carsonbot @fabpot @alexander-schranz @lyrixx @chalasr