Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create permutation&combination #1594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@Satyamchaubey07
Copy link
Task lists! Give feedback

@Satyamchaubey07 Satyamchaubey07 commented Sep 6, 2021

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@mishraabhinn
Copy link
Member

@mishraabhinn mishraabhinn commented Sep 6, 2021

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

HI @Satyamchaubey07
This can be included in maths folder. But the code you have written is not upto the repository standards. Please read the contribution guidelines. For better understanding of the pr standard we are looking is by checking the recently merged pr. Thanks!

Screenshot 2021-09-06 at 17 25 27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants