Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SERVER-59010 Fix SSL off build, OCSPManager shouldn't be used when ssl = off #1401

Open
wants to merge 1 commit into
base: v4.4
Choose a base branch
from
Open

SERVER-59010 Fix SSL off build, OCSPManager shouldn't be used when ssl = off #1401

wants to merge 1 commit into from

Conversation

renanccastro
Copy link

@renanccastro renanccastro commented Mar 24, 2021 •
edited

When building with SSL=off, latest 4.4.4 release doesn't compile with the following error:

src/mongo/db/db.cpp:340: error: undefined reference to 'mongo::OCSPManager::startThreadPool()'
src/mongo/util/net/ocsp/ocsp_manager.h:49: error: undefined reference to 'mongo::OCSPManager::OCSPManager()'
collect2: error: ld returned 1 exit status
scons: *** [build/opt/mongo/mongod] Error 1
scons: building terminated because of errors.
build/opt/mongo/mongod failed: Error 1

OCSPManager thread pool probably shouldn't be started when SSL is off, as this class is not compiled in the presence of such an option.

Also some info here: https://developer.mongodb.com/community/forums/t/failure-to-build-mongodb-4-4-4/100231

This is blocking Meteor build of MongoDB, as we do use a small binary without SSL for development easiness.

The last version it was working is : MONGODB_VERSION='4.2.8'

@renanccastro renanccastro mentioned this pull request Apr 13, 2021
Open
@edzh
Copy link

@edzh edzh commented Aug 2, 2021

Thanks for making this pull request! We just need a couple of things from you to start our consideration of the PR. Can you please:

  1. Sign our Contributor's Agreement.
  2. Create a new SERVER ticket on JIRA.

@renanccastro
Copy link
Author

@renanccastro renanccastro commented Aug 2, 2021

Hello @edzh
Thanks for answering

I've created the issue and signed the agreement.

https://jira.mongodb.org/browse/SERVER-59010

@edzh edzh changed the title Fix SSL off build, OCSPManager shouldn't be used when ssl = off SERVER-59010 Fix SSL off build, OCSPManager shouldn't be used when ssl = off Aug 3, 2021
@spencerjackson spencerjackson self-requested a review Sep 29, 2021
spencerjackson
spencerjackson approved these changes Sep 29, 2021
View changes
Copy link
Contributor

@spencerjackson spencerjackson left a comment

This change LGTM. I'm going to merge it along with a backport of SERVER-50050 to handle dynamic builds as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerjackson spencerjackson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@renanccastro @edzh @spencerjackson