Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sls package --aws-s3-accelerate #9812

Open
JamesKyburz opened this issue Aug 6, 2021 · 4 comments · May be fixed by #9814
Open

sls package --aws-s3-accelerate #9812

JamesKyburz opened this issue Aug 6, 2021 · 4 comments · May be fixed by #9814
Labels
bug cat/cli good first issue help wanted

Comments

Assignees
No one assigned
Labels
bug cat/cli good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix: aws-s3-accelerate for package fixes #9812
2 participants
@JamesKyburz @pgrzesik
@JamesKyburz
Copy link

@JamesKyburz JamesKyburz commented Aug 6, 2021

Using version 2.53.0

When executing sls package --aws-s3-accelerate we get an incorrect deprecation warning.

Serverless: Packaging service...
Serverless: Deprecation warning: Detected unrecognized CLI options: "--aws-s3-accelerate".

However the cloudformation output contains the correct s3 bucket configuration.

"AccelerateConfiguration": {
  "AccelerationStatus": "Enabled"
}

If the option is removed from the package command prior to a deploy it fails.

sls package
sls deploy --package .serverless --aws-s3-accelerate
 Serverless Error ----------------------------------------
 
  S3 Transfer Acceleration is not configured on this bucket

Installed version

2.53.0
@JamesKyburz
Copy link
Author

@JamesKyburz JamesKyburz commented Aug 6, 2021

Am happy to submit a PR but was not sure if the code should be added to the lib/cli/commands-schema/aws-service.js

Loading

@pgrzesik
Copy link
Member

@pgrzesik pgrzesik commented Aug 6, 2021

Hello @JamesKyburz, thanks for reporting. It looks like that option was ommitted when options schema was introduces and yes, it should be added to the module you've linked. We'd be more than happy to accept a PR 🙇

Loading

JamesKyburz added a commit to JamesKyburz/serverless that referenced this issue Aug 6, 2021
@JamesKyburz
fix: aws-s3-accelerate for package fixes serverless#9812
f5036a7
@JamesKyburz
Copy link
Author

@JamesKyburz JamesKyburz commented Aug 6, 2021

Thanks, will send a PR.

Loading

@JamesKyburz JamesKyburz linked a pull request that will close this issue Aug 8, 2021
Open
@JamesKyburz
Copy link
Author

@JamesKyburz JamesKyburz commented Aug 8, 2021

Sent a simple PR and have verified it works locally with npm link.

Loading

JamesKyburz added a commit to JamesKyburz/serverless that referenced this issue Oct 29, 2021
@JamesKyburz
fix: aws-s3-accelerate cli option for aws fixes serverless#9812
87d6c65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment