Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enable X509_V_FLAG_TRUSTED_FIRST flag in BoringSSL #31218

Merged
merged 2 commits into from Sep 30, 2021
Merged

fix: Enable X509_V_FLAG_TRUSTED_FIRST flag in BoringSSL #31218

merged 2 commits into from Sep 30, 2021
+21 −0

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Sep 30, 2021

Backport of #31213

See that PR for details.

Notes: Fix Let's Encrypt DST Root CA X3 certificate expiration.
@jviotti @electron-bot
fix: Enable X509_V_FLAG_TRUSTED_FIRST flag in BoringSSL
f899897 
Fixes: #31212
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@trop trop bot requested a review from as a code owner Sep 30, 2021
@trop trop bot mentioned this pull request Sep 30, 2021
Merged
4 tasks
VerteDinde
VerteDinde requested changes Sep 30, 2021
View changes
Copy link
Member

@VerteDinde VerteDinde left a comment

One extra patch

clavin
clavin requested changes Sep 30, 2021
View changes
Copy link
Member

@clavin clavin left a comment

Extra patches

@MarshallOfSound
Update .patches
342b7f2
MarshallOfSound
MarshallOfSound approved these changes Sep 30, 2021
View changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

👍 bad merge fixed

clavin
clavin approved these changes Sep 30, 2021
View changes
VerteDinde
VerteDinde requested changes Sep 30, 2021
View changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Hold for linux-x64-testing

@VerteDinde VerteDinde merged commit d788d81 into 15-x-y Sep 30, 2021
10 of 14 checks passed
@VerteDinde VerteDinde deleted the trop/15-x-y-bp-fix-enable-x509_v_flag_trusted_first-flag-in-boringssl-1633033394829 branch Sep 30, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Sep 30, 2021

Release Notes Persisted

Fix Let's Encrypt DST Root CA X3 certificate expiration.

deepak1556 added a commit that referenced this issue Sep 30, 2021
@deepak1556 @deepak1556
Revert "fix: Enable X509_V_FLAG_TRUSTED_FIRST flag in BoringSSL (#31218…
2c6dc75 
…)"

This reverts commit d788d81.
deepak1556 added a commit that referenced this issue Oct 1, 2021
@deepak1556 @deepak1556
fix: remove expired DST Root CA X3 (#31219)
9407a3e 
* Revert "fix: Enable X509_V_FLAG_TRUSTED_FIRST flag in BoringSSL (#31218)"

This reverts commit d788d81.

* fix: remove expired DST Root CA X3
@promatik promatik mentioned this pull request Oct 1, 2021
Closed
@NotWearingPants NotWearingPants mentioned this pull request Oct 3, 2021
Open
downace added a commit to vast-ru/electron-print-server that referenced this issue Oct 4, 2021
@downace
Upgrade to Electron 15
81ba5ca 
They fixed Let's Encrypt DST Root CA X3 certificate expiration for 12+ versions, see electron/electron#31218
@veado veado mentioned this pull request Oct 6, 2021
Merged
@jeffbarr jeffbarr mentioned this pull request Oct 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde

@MarshallOfSound MarshallOfSound

@clavin clavin

Assignees
No one assigned
Labels
15-x-y backport fast-track 🚅 semver/patch
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@VerteDinde @MarshallOfSound @clavin @jviotti