Skip to content

refactor: pass webPreferences over mojo IPC instead of command-line #19043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 29, 2019

Description of Change

Pass all required webPreferences (such as the list of preload scripts) via native mojo IPC as the command-line is shared when the same renderer process is hosting multiple BrowserWindows (scriptable popup with nativeWindowOpen: true for example).

Fixes #18466

Checklist

Release Notes

Notes: Preload scripts configured for popups when handling the new-window event now work properly regardless of whether a new renderer process is hosting the contents (cross-origin) or the same renderer (same-origin).

@miniak miniak added the wip ⚒ label Jun 29, 2019
@miniak miniak self-assigned this Jun 29, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 29, 2019
@miniak miniak force-pushed the miniak/web-preferences-mojo branch 2 times, most recently from dc4a627 to 4fde24c Compare June 29, 2019 09:41
@miniak miniak force-pushed the miniak/web-preferences-mojo branch 8 times, most recently from 462c4ec to d91fe61 Compare June 29, 2019 14:56
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 30, 2019
@miniak miniak force-pushed the miniak/web-preferences-mojo branch 3 times, most recently from 9cb08a4 to 4bb5079 Compare July 1, 2019 22:06
@miniak miniak force-pushed the miniak/web-preferences-mojo branch from 4bb5079 to 832cd0e Compare July 5, 2019 13:35
@miniak miniak mentioned this pull request Jun 25, 2020
7 tasks
@miniak
Copy link
Contributor Author

miniak commented Nov 17, 2020

Replaced by #24517

@miniak miniak closed this Nov 17, 2020
@miniak miniak deleted the miniak/web-preferences-mojo branch January 27, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background color ignored on scriptable BrowserWindow
1 participant