New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datepicker): add ability to also show time #9570
Merged
NathanWalker
merged 12 commits into
release/8.2.0
from
feat/ui-datepicker-with-time-option
Mar 5, 2022
Merged
feat(datepicker): add ability to also show time #9570
NathanWalker
merged 12 commits into
release/8.2.0
from
feat/ui-datepicker-with-time-option
Mar 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still needs the Android side done before we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR Checklist
What is the current behavior?
DatePicker
did not allow the ability to show a time picker alongside the date. Although there is a distinctTimePicker
in core, it was often not flexible enough in the sense of how one would often need to use a date picker with time picker.What is the new behavior?
DatePicker
now supports ashowTime
property which will allow the date and the time to be set properly.This also adds properties for hour, minute and second as well as a proper attribute for
iosPreferredDatePickerStyle
to allow easy dynamic view binding.Further this can be useful in scenarios where this plugin may not fit the exact use case given how it creates two separate native controls vs. just one with these changes.