Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in a comment in Modules/_ssl.c: s/validata/validate/ #27993

Merged
merged 1 commit into from Aug 27, 2021
Merged

Fix typo in a comment in Modules/_ssl.c: s/validata/validate/ #27993

merged 1 commit into from Aug 27, 2021

Conversation

adamtheturtle
Copy link
Contributor

@adamtheturtle adamtheturtle commented Aug 27, 2021

"validata" -> "validate"

@adamtheturtle
Fix typo in a comment
8098d04 
"validata" -> "validate"
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Aug 27, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@adamtheturtle

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@ambv
Copy link
Contributor

ambv commented Aug 27, 2021

Rationale for backporting to 3.8 is that while this isn't a sec-fix itself, it will decrease likelihood of conflicts for actual sec-fixes in the future.

@ambv ambv changed the title Fix typo in a comment Fix typo in a comment in Modules/_ssl.c: s/validata/validate/ Aug 27, 2021
@ambv ambv merged commit 28db1f6 into python:main Aug 27, 2021
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 27, 2021

Thanks @adamtheturtle for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Aug 27, 2021

GH-27997 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2021
@adamtheturtle @miss-islington
Fix typo in a comment in Modules/_ssl.c: s/validata/validate/ (python…
28141fc 
…GH-27993)

(cherry picked from commit 28db1f6)

Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 27, 2021

GH-27998 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2021
@adamtheturtle @miss-islington
Fix typo in a comment in Modules/_ssl.c: s/validata/validate/ (python…
841e692 
…GH-27993)

(cherry picked from commit 28db1f6)

Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 27, 2021

GH-27999 is a backport of this pull request to the 3.8 branch.

ambv pushed a commit that referenced this pull request Aug 27, 2021
@miss-islington @adamtheturtle
Fix typo in a comment in Modules/_ssl.c: s/validata/validate/ (GH-27993…
2351ff2 
…) (GH-27998)

(cherry picked from commit 28db1f6)

Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
ambv pushed a commit that referenced this pull request Aug 27, 2021
@miss-islington @adamtheturtle
Fix typo in a comment in Modules/_ssl.c: s/validata/validate/ (GH-27993…
44dd2ec 
…) (GH-27999)

(cherry picked from commit 28db1f6)

Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
@adamtheturtle adamtheturtle deleted the patch-1 branch Aug 27, 2021
ned-deily pushed a commit that referenced this pull request Sep 6, 2021
@miss-islington
Fix typo in a comment in Modules/_ssl.c: s/validata/validate/ (GH-27993…
e5f259e 
…) (GH-27997)

(cherry picked from commit 28db1f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adamtheturtle @the-knights-who-say-ni @ambv @miss-islington @bedevere-bot