Skip to content

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45019: Do some cleanup related to frozen modules. #28319

Merged
merged 19 commits into from Sep 13, 2021
Merged

bpo-45019: Do some cleanup related to frozen modules. #28319

merged 19 commits into from Sep 13, 2021

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Sep 13, 2021 •
edited

There are a few things I missed in gh-27980. This is a follow-up that will make subsequent PRs cleaner. It includes fixes to tests and tools that reference the frozen modules.

(FYI, these changes come from gh-28107. @gvanrossum already reviewed them there.)

https://bugs.python.org/issue45019
@ericsnowcurrently
Fix freeze_module() in freeze_modules.py.
63cd6f6
@ericsnowcurrently
Add FrozenSource and FrozenModule to freeze_modules.py.
0223e32
@ericsnowcurrently
Leave all non-required frozen modules uncommitted.
a2be976
@ericsnowcurrently
Leave *all* frozen modules uncommitted.
7a9d113
@ericsnowcurrently
Generate the list of frozen modules used by test_ctypes.
e0f264f
@ericsnowcurrently
Ignore frozen submodules in generate_stdlib_module_names.py.
c4cea0f
@ericsnowcurrently
Add a comment to the frozen modules manifest file.
1336b4e
@ericsnowcurrently
Show how the frozen manifest changed.
122492a
@ericsnowcurrently
Go back to keeping frozen modules in the repo.
4c1bc81
@ericsnowcurrently
Also stop tracking the frozen manifest.
cd99280
@ericsnowcurrently
Mark the frozen manifest as a generated file.
65a9562
@ericsnowcurrently
Drop a superfluous prefix on makefile rule dependencies.
122e642
@ericsnowcurrently
Do not generate test code.
0704664
@ericsnowcurrently
Drop unused code from freeze_modules.py.
81d70ea
@ericsnowcurrently
Do not clear the frozen .h files with "make distclean", now that they…
a61afbd 
… are back in the repo.
@ericsnowcurrently
Always flush the printed "title" when freezing modules.
ca35ee8
@ericsnowcurrently
Add the frozen manifest back into the repo.
1bf4d2f
@ericsnowcurrently
On Windows, only freeze the essential modules for now.
bd129b5
@ericsnowcurrently
Drop an outdated call.
20d3b50
@ericsnowcurrently ericsnowcurrently changed the title bpo-45019: Frozen modules cleanup 2 bpo-45019: Do some cleanup related to frozen modules. Sep 13, 2021
@ericsnowcurrently ericsnowcurrently mentioned this pull request Sep 13, 2021
Closed
@ericsnowcurrently ericsnowcurrently merged commit a2d8c4b into python:main Sep 13, 2021
11 checks passed
@ericsnowcurrently ericsnowcurrently deleted the frozen-modules-cleanup-2 branch Sep 15, 2021
@ericsnowcurrently ericsnowcurrently mentioned this pull request Sep 15, 2021
Merged
ericsnowcurrently added a commit that referenced this issue Sep 15, 2021
@ericsnowcurrently
bpo-45019: Silence a warning in test_ctypes. (gh-28362)
4b30aaa 
This was missed in PR gh-28319.

https://bugs.python.org/issue45019
@ericsnowcurrently ericsnowcurrently mentioned this pull request Sep 15, 2021
Merged
ericsnowcurrently added a commit that referenced this issue Sep 15, 2021
@ericsnowcurrently
bpo-45019: Clean up the frozen __hello__ module. (gh-28374)
3814e20 
Here's one more small cleanup that should have been in PR gh-28319. We eliminate stdout side-effects from importing the frozen __hello__ module, and update tests accordingly. We also move the module's source file into Lib/ from Toos/freeze/flag.py.

https://bugs.python.org/issue45019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon

@encukou encukou

@ncoghlan ncoghlan

@warsaw warsaw

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
3 participants
@ericsnowcurrently @the-knights-who-say-ni @bedevere-bot