Skip to content

feat(common): expose the validate method as an option in ValidationPipe #8208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

feat(common): expose the validate method as an option in ValidationPipe #8208

merged 1 commit into from
Oct 13, 2021

Conversation

aboqasem
Copy link
Contributor

@aboqasem aboqasem commented Oct 3, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #8207

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Oct 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 926b4e62-6922-46c5-9e2d-44fbd516cd62

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 38 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.08%) to 94.289%
Files with Coverage Reduction New Missed Lines %
packages/common/pipes/parse-array.pipe.ts 3 90.91%
packages/microservices/client/client-nats.ts 4 88.57%
packages/microservices/server/server-nats.ts 4 88.07%
packages/microservices/client/client-mqtt.ts 5 91.26%
packages/microservices/server/server-rmq.ts 5 81.82%
packages/microservices/server/server-mqtt.ts 6 83.76%
packages/microservices/client/client-rmq.ts 11 84.82%
Totals Coverage Status
Change from base Build 2a169b7b-0d40-48f8-a1ca-50a4c5af1220: -0.08%
Covered Lines: 5531
Relevant Lines: 5866
💛 - Coveralls

@aboqasem aboqasem changed the title Expose the validate method as an option in ValidationPipe feat(common): expose the validate method as an option in ValidationPipe Oct 3, 2021
@aboqasem aboqasem mentioned this pull request Oct 3, 2021
Closed
10 tasks
@kamilmysliwiec kamilmysliwiec mentioned this pull request Oct 8, 2021
Closed
@kamilmysliwiec kamilmysliwiec merged commit 42c89e0 into nestjs:master Oct 13, 2021
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilmysliwiec kamilmysliwiec kamilmysliwiec left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aboqasem @coveralls @kamilmysliwiec