build: update rollup dependencies #43737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: major
alan-agius4
added
target: rc
With this change we update `rollup` and remove the usage of no longer maintained `rollup-plugin-commonjs` and `rollup-plugin-node-resolve` plugins.
We can now update to the latest rollup version.
gkalpak
approved these changes
Oct 13, 2021
|
|
||
| // Parse the stamp file produced by Bazel from the version control system | ||
| let version = '<unknown>'; | ||
| if (bazel_version_file) { | ||
| const versionTag = require('fs') | ||
| .readFileSync(bazel_version_file, {encoding: 'utf-8'}) | ||
| .split('\n') | ||
| .find(s => s.startsWith('BUILD_SCM_VERSION')); | ||
| .find((s) => s.startsWith('BUILD_SCM_VERSION')); |
There was a problem hiding this comment.
I thought it was ng-dev, but now I realise it’s the prettier vscode plugin.
JiaLiPassion
approved these changes
Oct 13, 2021
alan-agius4
added
action: merge
|
This PR was merged into the repository by commit 6b85519. |
atscott
pushed a commit
that referenced
this pull request
Oct 13, 2021
With this change we update `rollup` and remove the usage of no longer maintained `rollup-plugin-commonjs` and `rollup-plugin-node-resolve` plugins. PR Close #43737
atscott
pushed a commit
that referenced
this pull request
Oct 13, 2021
We can now update to the latest rollup version. PR Close #43737
atscott
pushed a commit
that referenced
this pull request
Oct 13, 2021
We can now update to the latest rollup version. PR Close #43737
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we update
rollupand remove the usage of no longer maintainedrollup-plugin-commonjsandrollup-plugin-node-resolveplugins.