Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] bpo-45401: Fix a resource warning in test_logging (GH-28864) #28872

Merged
merged 1 commit into from
Oct 12, 2021
Merged

[3.10] bpo-45401: Fix a resource warning in test_logging (GH-28864) #28872

merged 1 commit into from
Oct 12, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 11, 2021 •
edited by bedevere-bot
Loading

(cherry picked from commit 15188b1)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com

https://bugs.python.org/issue45401

@serhiy-storchaka @miss-islington
bpo-45401: Fix a resource warning in test_logging (pythonGH-28864)
535653b 
(cherry picked from commit 15188b1)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 11, 2021
@miss-islington
Copy link
Contributor Author

@serhiy-storchaka: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@serhiy-storchaka: Status check is done, and it's a failure ❌ .

@bedevere-bot bedevere-bot mentioned this pull request Oct 11, 2021
Merged
@miss-islington
Copy link
Contributor Author

@serhiy-storchaka: Status check is done, and it's a failure ❌ .

vstinner
vstinner approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@serhiy-storchaka serhiy-storchaka merged commit 47a50fe into python:3.10 Oct 12, 2021
@miss-islington miss-islington deleted the backport-15188b1-3.10 branch October 12, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @vstinner @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot