bpo-45434: Mark the PyTokenizer C API as private #28924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename PyTokenize functions to mark them as private: * PyTokenizer_FindEncodingFilename() => _PyTokenizer_FindEncodingFilename() * PyTokenizer_FromString() => _PyTokenizer_FromString() * PyTokenizer_FromFile() => _PyTokenizer_FromFile() * PyTokenizer_FromUTF8() => _PyTokenizer_FromUTF8() * PyTokenizer_Free() => _PyTokenizer_Free() * PyTokenizer_Get() => _PyTokenizer_Get() Remove the unused PyTokenizer_FindEncoding() function. import.c: remove unused #include "errcode.h".
vstinner
requested review from
brettcannon,
encukou,
ericsnowcurrently,
lysnikolaou,
ncoghlan,
pablogsal and
warsaw
as code owners
pablogsal
approved these changes
Oct 13, 2021
|
@pablogsal @isidentical @lysnikolaou: Do you see any reason to keep the PyTokenizer as public? My plan is to move E_xxx constants from Include/errcode.h to Include/internal/pycore_parser.h, and then remove the Include/errcode.h header filer. |
isidentical
approved these changes
Oct 13, 2021
I don't see any reason for external apps to depend on these methods, especially when we already have a pure Python version. |
In fact, it's not possible without breaking the backward compatibility: https://bugs.python.org/issue45434#msg403841 |
|
But marking the tokenizer C API as private is still worth it ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename PyTokenize functions to mark them as private:
Remove the unused PyTokenizer_FindEncoding() function.
import.c: remove unused #include "errcode.h".
https://bugs.python.org/issue45434