Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45439: Move _PyObject_CallNoArgs() to pycore_call.h #28895

Merged
merged 1 commit into from Oct 12, 2021
Merged

bpo-45439: Move _PyObject_CallNoArgs() to pycore_call.h #28895

merged 1 commit into from Oct 12, 2021
+89 −64

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 12, 2021 •
edited by bedevere-bot

  • Move _PyObject_CallNoArgs() to pycore_call.h (internal C API).
  • _ssl, _sqlite and _testcapi extensions now call the public
    PyObject_CallNoArgs() function, rather than _PyObject_CallNoArgs().
  • _lsprof extension is now built with Py_BUILD_CORE_MODULE macro
    defined to get access to internal _PyObject_CallNoArgs().

https://bugs.python.org/issue45439
@vstinner vstinner mentioned this pull request Oct 12, 2021
Open
@vstinner
bpo-45439: Move _PyObject_CallNoArgs() to pycore_call.h
7e94cc2 
* Move _PyObject_CallNoArgs() to pycore_call.h (internal C API).
* _ssl, _sqlite and _testcapi extensions now call the public
  PyObject_CallNoArgs() function, rather than _PyObject_CallNoArgs().
* _lsprof extension is now built with Py_BUILD_CORE_MODULE macro
  defined to get access to internal _PyObject_CallNoArgs().
@vstinner vstinner force-pushed the internal_noargs branch from e465ed5 to 7e94cc2 Oct 12, 2021
@vstinner vstinner merged commit d943d19 into python:main Oct 12, 2021
12 checks passed
@vstinner vstinner deleted the internal_noargs branch Oct 12, 2021
@vstinner
Copy link
Member Author

@vstinner vstinner commented Oct 12, 2021

Thanks @methane for the review, I merged my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane

@1st1 1st1

@berkerpeksag berkerpeksag

@ethanfurman ethanfurman

@lysnikolaou lysnikolaou

@markshannon markshannon

@pablogsal pablogsal

@rhettinger rhettinger

@tiran tiran

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@vstinner @methane @the-knights-who-say-ni @bedevere-bot