Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 page does not support i18n #1987

Open
1 task done
haoranpb opened this issue Oct 27, 2019 · 6 comments
Open
1 task done

404 page does not support i18n #1987

haoranpb opened this issue Oct 27, 2019 · 6 comments
Labels
complexity: easy contribution welcome effort: medium good first issue topic: theme type: feature request

Comments

@haoranpb
Copy link
Contributor

@haoranpb haoranpb commented Oct 27, 2019

  • I confirm that this is an issue rather than a question.

Bug report

I just find this on stackoverflow, and test it on the official website

Steps to reproduce

Try to visit vuepress.vuejs.org/zh/test

What is expected?

A 404 page with Chinese and

<html lang="zh-CN" >

What is actually happening?

<html lang="en-US" >

Other relevant information

  • Output of npx vuepress info in my VuePress project:
@kefranabg kefranabg added type: feature request good first issue contribution welcome complexity: easy effort: medium topic: theme labels Nov 1, 2019
@sybers
Copy link

@sybers sybers commented Nov 6, 2019

Hello @ludanxer, this seems like a good fist issue for me on this project !
I will submit a PR for it later this week ;)

@ThaddeusJiang
Copy link

@ThaddeusJiang ThaddeusJiang commented Apr 1, 2020

Hi @dzetah
Did you submit a PR?

@haoranpb
Copy link
Contributor Author

@haoranpb haoranpb commented Apr 1, 2020

Yes, he kindly did #2004 , I believe it's not ready because

Currently, it will show the default messages first, and change to the locale messages.

It's not so perfect 🤔

https://deploy-preview-2004--vuepress.netlify.com/zh/guide/aaa

demo-locale

@sybers
Copy link

@sybers sybers commented Apr 1, 2020

Hi @dzetah

Did you submit a PR?

Yes I did but I have to fix it because there’s a still a small bug. I had no time at all to do that recently, I’ll try to do it this week.

@faraz16iqbal
Copy link

@faraz16iqbal faraz16iqbal commented Sep 27, 2021

Hey, is this issue still open?

@Juninhoww2
Copy link

@Juninhoww2 Juninhoww2 commented Oct 22, 2021

Yes @faraz16iqbal

yamashita-ki pushed a commit to yamashita-ki/vuepress that referenced this issue Dec 11, 2021
fix(): localize 404 page fix vuejs#1987
80bb379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity: easy contribution welcome effort: medium good first issue topic: theme type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kefranabg @sybers @ThaddeusJiang @Juninhoww2 @haoranpb @faraz16iqbal