Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45428: Strip trailing '\n' from filename #28848

Merged
merged 3 commits into from Oct 15, 2021
Merged

bpo-45428: Strip trailing '\n' from filename #28848

merged 3 commits into from Oct 15, 2021
+2 −1

Conversation

@ginggs
Copy link
Contributor

@ginggs ginggs commented Oct 10, 2021 •
edited by bedevere-bot

This was dropped in daff390 and breaks reading the list of files to compile from stdin

https://bugs.python.org/issue45428
@ginggs
Strip trailing '\n' from filename
dd0105f 
This was dropped in daff390 and breaks reading the list of files to compile from stdin
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Oct 10, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@ginggs

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Mariatta
Copy link
Member

@Mariatta Mariatta commented Oct 10, 2021

Please create an issue about this in bugs.python.org and describe the problem.

@ginggs ginggs changed the title Strip trailing '\n' from filename bpo-45428: Strip trailing '\n' from filename Oct 11, 2021
@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 12, 2021

'\n' should only be stripped if read file name from stdin.

@ginggs
Only strip '\n' when reading from stdin
313895d
@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 14, 2021

Please add a NEWS entry. https://blurb-it.herokuapp.com/

@blurb-it
📜🤖 Added by blurb_it.
bebef05
@serhiy-storchaka serhiy-storchaka merged commit 59a633d into python:main Oct 15, 2021
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 15, 2021

Thanks @ginggs for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 15, 2021

GH-28971 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Oct 15, 2021
@ginggs @miss-islington
bpo-45428: Fix reading filenames from stdin in py_compile (pythonGH-2…
fad595a 
…8848)

Strip trailing '\n'.
(cherry picked from commit 59a633d)

Co-authored-by: Graham Inggs <ginggs@debian.org>
@ginggs ginggs deleted the patch-1 branch Oct 15, 2021
miss-islington added a commit that referenced this issue Oct 15, 2021
@ginggs @miss-islington
bpo-45428: Fix reading filenames from stdin in py_compile (GH-28848)
2b6eb81 
Strip trailing '\n'.
(cherry picked from commit 59a633d)

Co-authored-by: Graham Inggs <ginggs@debian.org>
ShivnarenSrinivasan added a commit to ShivnarenSrinivasan/cpython that referenced this issue Oct 15, 2021
@ginggs @ShivnarenSrinivasan
bpo-45428: Fix reading filenames from stdin in py_compile (pythonGH-2…
c50770d 
…8848)

Strip trailing '\n'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

Assignees
No one assigned
Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
6 participants
@ginggs @the-knights-who-say-ni @Mariatta @serhiy-storchaka @miss-islington @bedevere-bot