Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

while generating appShell option appDir is ignored #17813

Open
1 of 15 tasks
santoshyadavdev opened this issue May 28, 2020 · 2 comments · May be fixed by #17816
Open
1 of 15 tasks

while generating appShell option appDir is ignored #17813

santoshyadavdev opened this issue May 28, 2020 · 2 comments · May be fixed by #17816
Labels
comp: schematics/angular freq1: low good first issue triage #1 type: bug/fix
Milestone
needsTriage

Comments

@santoshyadavdev
Copy link
Contributor

@santoshyadavdev santoshyadavdev commented May 28, 2020 •
edited

🐞 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Is this a regression?

Yes, the previous version in which this bug was not present was: ....

We have an application with universal, where the app.server.module.ts file is not in app folder, when I tried to use ng generate appShell --appDir='path' it ignores it throws exception

Specified module 'app.server.module.ts' does not exist.
Looked in the following directories:
/src/app/app.server.module.ts
/src/app/app-shell
/src/app
/src

Description

A clear and concise description of the problem...

🔬 Minimal Reproduction

🔥 Exception or Error




Specified module 'app.server.module.ts' does not exist.
Looked in the following directories:
/src/app/app.server.module.ts
/src/app/app-shell
/src/app
/src

🌍 Your Environment




Angular CLI: 9.0.5
Node: 12.14.1
OS: win32 x64

Angular: 9.0.5
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.5
@angular-devkit/build-angular     0.900.5
@angular-devkit/build-optimizer   0.900.5
@angular-devkit/build-webpack     0.900.5
@angular-devkit/core              9.0.5
@angular-devkit/schematics        9.0.5
@ngtools/webpack                  9.0.5
@nguniversal/builders             9.0.1
@nguniversal/common               9.0.1
@nguniversal/express-engine       9.0.1
@schematics/angular               9.0.5
@schematics/update                0.900.5
rxjs                              6.5.4
typescript                        3.7.5
webpack                           4.41.2

Anything else relevant?
@ngbot ngbot bot added this to the needsTriage milestone May 28, 2020
@ngbot ngbot bot added this to the needsTriage milestone May 28, 2020
@santoshyadavdev
Copy link
Contributor Author

@santoshyadavdev santoshyadavdev commented May 28, 2020

Hi @alan-agius4 will take it.

santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue May 28, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
59ad998 
fixes angular#17813
@santoshyadavdev santoshyadavdev mentioned this issue May 28, 2020
Closed
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue May 28, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
e660467 
fixes angular#17813
@santoshyadavdev santoshyadavdev linked a pull request that will close this issue May 28, 2020
Draft
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 1, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
09967cc 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 1, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
09ce53d 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 1, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
5fe0bf3 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 1, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
e437829 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 2, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
2924bc7 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 2, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
e66d253 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 3, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
4624040 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 3, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
7ea2cbb 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 3, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
a3650bc 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 3, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
344e6fd 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 3, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
4ec8641 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 3, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
595f9d3 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 3, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
4fb9216 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 3, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
a5fa1ec 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 7, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
bd60f8b 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 7, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
8d04313 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 7, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
ff3fb41 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 7, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
b5361aa 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 7, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
817202f 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 7, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
8aa11d5 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 8, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
bd2e227 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 8, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
9f46de1 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 8, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
664dbf4 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 8, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
1b41589 
fixes angular#17813
santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Jun 8, 2020
@santoshyadavdev
fix(@schematics/angular): add appDir option
ba44abc 
fixes angular#17813
@abadi003
Copy link

@abadi003 abadi003 commented Jan 13, 2021

is this still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: schematics/angular freq1: low good first issue triage #1 type: bug/fix
Projects
None yet
Milestone
needsTriage
Linked pull requests

Successfully merging a pull request may close this issue.

fix(@schematics/angular): add appDir option
fix(@schematics/angular): add appDir option
3 participants
@santoshyadavdev @alan-agius4 @abadi003