Skip to content

Removing obsolete files from stdlib #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

jamestwebber
Copy link
Contributor

This is a WIP. I just noticed that the copy of the stdlib was likely copied from 3.7 and some things were gradually updated. Some of the files in there are no longer present in later versions so I should I'd open a PR to just remove them. But some of these will require additional modifications (i.e. they were being imported in older versions of other modules) so I still need to check what is broken before making this a real PR.

@coolreader18
Copy link
Member

I know at the very least I'd like to keep [_]dummy_thread[ing].py - cpython has dropped the ability to disable threading, but we still target platforms like wasm where threading isn't available. Though maybe at some point it'd be easier to just stub out _thread on platforms where it's not supported.

@jamestwebber
Copy link
Contributor Author

I know at the very least I'd like to keep [_]dummy_thread[ing].py - cpython has dropped the ability to disable threading, but we still target platforms like wasm where threading isn't available.

Hm interesting, that's a good point. And maybe this is an overly broad change anyway.

I had started by just checking for python modules that had changed between 3.7 and 3.8 / 3.9 / 3.10 and then noticed some of them are just gone at this point. As it seems like RustPython is still aiming at a moving target re: compatibility, I figured I'd remove these to start and see what happened.

@jamestwebber
Copy link
Contributor Author

platforms like wasm where threading isn't available

Although: is this still true in this specific case? I'm not a wasm expert but it appears it has threads now?

@fanninpm
Copy link
Contributor

Although: is this still true in this specific case? I'm not a wasm expert but it appears it has threads now?

It depends on how recent your browser is. This exact feature is not on caniuse.com, but there's an open issue in the caniuse repo.

@jamestwebber
Copy link
Contributor Author

Coming up on a year anniversary, I think this is quite out of date. Closing but might revisit someday.

@jamestwebber jamestwebber deleted the deleting-things branch July 14, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants