Feat/python3.10 support #7126
Merged
Feat/python3.10 support #7126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marksweb
reviewed
Jan 8, 2022
On Python 3.10 django emits a warning (DeprecationWarning) for asyncio run - https://stackoverflow.com/questions/70303895/python-3-10-asyncio-gather-shows-deprecationwarning-there-is-no-current-event We filter out this warning here, since it is not relevant to our test and still have the tests in place so that I can check for this behaviour. - Github Issue: django-cms#7183 Authored-by: Vinit Kumar <vinit.kumar@socialschools.nl> Signed-off-by: Vinit Kumar <vinit.kumar@socialschools.nl>
Add latest stable version of Python3.10 and also remove Python3.6 since it EOL'ed in december, 2021 Authored-by: Vinit Kumar <vinit.kumar@socialschools.nl> Signed-off-by: Vinit Kumar <vinit.kumar@socialschools.nl>
|
I've created a brand new project to test this. Things run, and I can create pages. But I've done something wrong because I can't open the structure pane I create new projects so infrequently I always forget what causes this... Anyway, so far, so good |
marksweb
reviewed
Jan 18, 2022
marksweb
reviewed
Jan 23, 2022
.github/workflows/test.yml
Outdated
| @@ -8,7 +8,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python-version: [ 3.6, 3.7, 3.8, 3.9, ] # latest release minus three | |||
| python-version: [ 3.7, 3.8, 3.9, 3.10.2] # latest release minus three | |||
There was a problem hiding this comment.
If you convert these to strings then '3.10' should ensure we test the latest point release.
python-version: [ '3.7', '3.8', '3.9', '3.10']
And drop the comment maybe?
marksweb
reviewed
Jan 23, 2022
Authored-by: Vinit Kumar <vinit.kumar@socialschools.nl> Signed-off-by: Vinit Kumar <vinit.kumar@socialschools.nl>
…at/python3.10-support
…at/python3.10-support
Authored-by: Vinit Kumar <vinit.kumar@socialschools.nl> Signed-off-by: Vinit Kumar <vinit.kumar@socialschools.nl>
marksweb
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Python3.10 got released last evening. This adds support for Python3.10 in DjangoCMS. Python3.10 is still not available on Github actions to running this tests with 3.10-rc2. Don't merge it yet. Once 3.10 official is out on actions and all tests pass, then we merge it.
Related resources
Checklist
develop