Skip to content

/ SwiftWebUI

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expire sessions #3

Open
helje5 opened this issue Jun 29, 2019 · 3 comments
Open

Expire sessions #3

helje5 opened this issue Jun 29, 2019 · 3 comments
Labels
bug good first issue help wanted

Comments

@helje5
Copy link
Member

@helje5 helje5 commented Jun 29, 2019

Sessions currently live forever :-) This "just" needs a proper timer.
@hmerzin
Copy link

@hmerzin hmerzin commented Nov 12, 2019

Hi, I would very much like to take this issue. Where would be a good place to start?
@helje5
Copy link
Member Author

@helje5 helje5 commented Nov 14, 2019

The sessions are stored over here: https://github.com/SwiftWebUI/SwiftWebUI/blob/develop/Sources/SwiftWebUI/ViewHosting/NIOEndpoint.swift#L62

They would need to track information when they got last accessed, and then there would need to be an NIO event loop timer removing "too old" sessions from the map.
@hmerzin
Copy link

@hmerzin hmerzin commented Nov 15, 2019

Thanks! I will give it a go today.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@helje5 @hmerzin
You can’t perform that action at this time.