Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42222: Improve tests for invalid argument types in randrange() #29021

Merged
merged 1 commit into from Oct 19, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 18, 2021

There were duplicate tests and some tests were removed in previous commit.

https://bugs.python.org/issue42222

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Oct 18, 2021
@ambv ambv merged commit 5742416 into python:main Oct 19, 2021
11 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2021

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2021

Sorry @serhiy-storchaka and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 574241632bd19e56ed488ee4d8999aefc6a8d7cd 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2021

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2021

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 574241632bd19e56ed488ee4d8999aefc6a8d7cd 3.10

@ambv
Copy link
Contributor

ambv commented Oct 19, 2021

Forget the backport, the original change was in 3.11 actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants