Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45434: Include stdlib.h for specialize stat #29015

Merged
merged 1 commit into from Oct 18, 2021
Merged

bpo-45434: Include stdlib.h for specialize stat #29015

merged 1 commit into from Oct 18, 2021

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 18, 2021 •
edited by bedevere-bot 


Python/specialize.c:172:71: error: implicit declaration of function 'rand' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    sprintf(buf, "%s%u_%u.txt", dirname, (unsigned)clock(), (unsigned)rand());

https://bugs.python.org/issue45434

vstinner
vstinner approved these changes Oct 18, 2021
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM. Sorry, I didn't test every single way to build Python. I didn't know PRINT_SPECIALIZATION_STATS_TO_FILE macro!

@vstinner
Copy link
Member

vstinner commented Oct 18, 2021 •
edited by bedevere-bot

@corona10: You can use [bpo-45434](https://bugs.python.org/issue45434): , since it's the issue who introduced the regression, see: commit aac29af.

@corona10 corona10 changed the title no-issue: Include stdlib.h for specialize stat bpo-45434: Include stdlib.h for specialize stat Oct 18, 2021
@corona10 corona10 merged commit fd03917 into python:main Oct 18, 2021
11 checks passed
@corona10 corona10 deleted the fix_specialize_stat branch Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@markshannon markshannon

@Fidget-Spinner Fidget-Spinner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot