Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45434: pyport.h no longer includes <stdlib.h> #28914

Merged
merged 4 commits into from Oct 13, 2021
Merged

bpo-45434: pyport.h no longer includes <stdlib.h> #28914

merged 4 commits into from Oct 13, 2021

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 13, 2021 •
edited by bedevere-bot

Include <stdlib.h> explicitly in C files.

Python.h includes <wchar.h>.

https://bugs.python.org/issue45434
@vstinner
Copy link
Member Author

@vstinner vstinner commented Oct 13, 2021

The build fails on Windows because of these macros which use <stdlib.h>:

extern _invalid_parameter_handler _Py_silent_invalid_parameter_handler;
#define _Py_BEGIN_SUPPRESS_IPH { _invalid_parameter_handler _Py_old_handler = \
    _set_thread_local_invalid_parameter_handler(_Py_silent_invalid_parameter_handler);
#define _Py_END_SUPPRESS_IPH _set_thread_local_invalid_parameter_handler(_Py_old_handler); }

@vstinner
bpo-45434: pyport.h no longer includes <stdlib.h>
8b07d0a 
Include <stdlib.h> explicitly in C files.

Python.h includes <wchar.h>.
vstinner added 3 commits Oct 13, 2021
@vstinner
pycore_fileutils.h includes <stdlib.h>
1bc785f
@vstinner
Fix building errors.c on Windows
7e098e7
@vstinner
Fix PC\WinMain.c
fdcad53
@vstinner vstinner requested a review from as a code owner Oct 13, 2021
@vstinner vstinner merged commit aac29af into python:main Oct 13, 2021
12 checks passed
@vstinner vstinner deleted the stdlib branch Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot