Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import dnssecjava #209

Merged
merged 12 commits into from Jan 23, 2022
Merged

Import dnssecjava #209

merged 12 commits into from Jan 23, 2022

Conversation

ibauersachs
Copy link
Member

@ibauersachs ibauersachs commented Aug 15, 2021

Closes #172

@ibauersachs ibauersachs force-pushed the dnssec branch 3 times, most recently from 31976d5 to 3ccb913 Compare Aug 15, 2021
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Aug 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

93.8% 93.8% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Aug 15, 2021 •
edited

Codecov Report

Merging #209 (b37ba45) into master (4eff203) will increase coverage by 6.34%.
The diff coverage is 90.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #209      +/-   ##
============================================
+ Coverage     57.26%   63.61%   +6.34%     
- Complexity     2088     2735     +647     
============================================
  Files           163      178      +15     
  Lines         10907    12509    +1602     
  Branches       1573     1902     +329     
============================================
+ Hits           6246     7957    +1711     
+ Misses         4235     4081     -154     
- Partials        426      471      +45
Impacted Files Coverage Δ
.../main/java/org/xbill/DNS/dnssec/NSEC3ValUtils.java 77.61% <77.61%> (ø)
...main/java/org/xbill/DNS/dnssec/DnsSecVerifier.java 85.18% <85.18%> (ø)
src/main/java/org/xbill/DNS/dnssec/ValUtils.java 90.05% <90.05%> (ø)
.../java/org/xbill/DNS/dnssec/ValidatingResolver.java 92.38% <92.38%> (ø)
src/main/java/org/xbill/DNS/dnssec/KeyCache.java 96.07% <96.07%> (ø)
...in/java/org/xbill/DNS/ExtendedErrorCodeOption.java 98.14% <100.00%> (+0.07%) ⬆️
src/main/java/org/xbill/DNS/Mnemonic.java 92.53% <100.00%> (ø)
...java/org/xbill/DNS/dnssec/ByteArrayComparator.java 100.00% <100.00%> (ø)
...c/main/java/org/xbill/DNS/dnssec/FindKeyState.java 100.00% <100.00%> (ø)
.../java/org/xbill/DNS/dnssec/JustifiedSecStatus.java 100.00% <100.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eff203...b37ba45. Read the comment docs.

@ibauersachs ibauersachs added this to the v3.5 milestone Aug 24, 2021
@ibauersachs ibauersachs mentioned this pull request Aug 29, 2021
Closed
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Dec 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

92.4% 92.4% Coverage
0.0% 0.0% Duplication

@ibauersachs ibauersachs requested a review from nresare Dec 25, 2021
@ibauersachs
Copy link
Member Author

@ibauersachs ibauersachs commented Dec 25, 2021

@nresare I think this is ready for merging, can you have a look please? I'm mainly interested in comments about the API, the entire content is probably too much.

nresare
nresare approved these changes Jan 22, 2022
View changes
Copy link
Member

@nresare nresare left a comment

This is obviously a very substantial diff that it is difficult to review all aspects of, but I had a brief look and it seems to me like a solid improvement to dnsjava. Let's land this, and we can come back to any outstanding issues later :)

@ibauersachs ibauersachs merged commit f4f563b into master Jan 23, 2022
15 of 16 checks passed
@ibauersachs ibauersachs deleted the dnssec branch Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperxpro hyperxpro

@nresare nresare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5
Linked issues

Successfully merging this pull request may close these issues.

Merge dnssecjava into dnsjava
4 participants
@ibauersachs @codecov-commenter @nresare @hyperxpro