[mypyc] Add a simple irchecking analysis system #11283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new module for performing analysis checks on ir as several bugs in mypy had underlying issues in which the ir produced by mypy was invalid and guaranteed to have issues at runtime. For now the checks are relatively simple - the only two supported are some validity on basic blocks: that they terminate and that control ops reference a basic block within the same function. Error reporting is non-existent and instead we are just testing that the resulting error datatypes are what we expect. In the future we will need to incorporate the errors into the pretty-printer so that we can produce an ir dump that references where the error actually is. In addition it would be useful if we had an ir parser so we could have a test framework similar to other parts of mypyc in which we simply write the IR in text format instead of constructing the IR ast from within python.
JukkaL
reviewed
Oct 7, 2021
mypyc/analysis/ircheck.py
Outdated
|
|
||
| def check_funcdef(fn: FuncIR) -> List[FnError]: | ||
| """Check a list of basic blocks (e.g. from a function definition) in surrounding | ||
| context (e.g. args). |
There was a problem hiding this comment.
Docstring seems out of date.
For consistency, maybe name check_func_ir (funcdef usually means the corresponding mypy AST node).
mypyc/analysis/ircheck.py
Outdated
| pass | ||
|
|
||
|
|
||
| def check_funcdef_and_crash(fn: FuncIR) -> None: |
There was a problem hiding this comment.
Nits: The implies that this crashes unconditionally, and funcdef sounds like mypy ast terminology. Maybe something like check_ir_and_raise_on_error?
| @@ -0,0 +1,164 @@ | |||
| from typing import List, Union | |||
There was a problem hiding this comment.
Please add a short module-level docstring.
|
Also flake8 is failing. |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
* Introduce basic ir analysis checks Adds a new module for performing analysis checks on ir as several bugs in mypy had underlying issues in which the ir produced by mypy was invalid and guaranteed to have issues at runtime. For now the checks are relatively simple - the only two supported are some validity on basic blocks: that they terminate and that control ops reference a basic block within the same function. Error reporting is non-existent and instead we are just testing that the resulting error datatypes are what we expect. In the future we will need to incorporate the errors into the pretty-printer so that we can produce an ir dump that references where the error actually is. In addition it would be useful if we had an ir parser so we could have a test framework similar to other parts of mypyc in which we simply write the IR in text format instead of constructing the IR ast from within python. * Integrate ircheck analysis into ir tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new module for performing analysis checks on ir as several bugs
in mypy had underlying issues in which the ir produced by mypy was
invalid and guaranteed to have issues at runtime.
For now the checks are relatively simple - the only two supported are
some validity on basic blocks: that they terminate and that control
ops reference a basic block within the same function.
In addition it would be useful if we had an ir parser so we could have a
test framework similar to other parts of mypyc in which we simply write
the IR in text format instead of constructing the IR ast from within
python.
The first commit here implements the checking but not the presentation;
the second implements basic presentation and integrates it into the test framework.