Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove unnecessary husky gitignore file #42870

Closed
wants to merge 1 commit into from
Closed

build: remove unnecessary husky gitignore file #42870

wants to merge 1 commit into from

Conversation

Reviewers

@josephperrott josephperrott

Assignees
No one assigned
Labels
action: merge cla: yes comp: build & ci PullApprove: disable target: patch
Projects
None yet
Milestone
Backlog
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@devversion @josephperrott
@devversion
Copy link
Member

@devversion devversion commented Jul 15, 2021

We recently updated to Husky v7 through Renovate, but
as of Husky v7, a .gitignore file is no longer needed.
@devversion
build: remove unnecessary husky gitignore file
6a3173f 
We recently updated to Husky v7 through Renovate, but
as of Husky v7, a `.gitignore` file is no longer needed.

This commit removes the file.
@devversion devversion requested a review from josephperrott Jul 15, 2021
@ngbot ngbot bot added this to the Backlog milestone Jul 15, 2021
@google-cla google-cla bot added the cla: yes label Jul 15, 2021
josephperrott
josephperrott approved these changes Jul 16, 2021
View changes
Copy link
Member

@josephperrott josephperrott left a comment

LGTM

Loading

@devversion
Copy link
Member Author

@devversion devversion commented Jul 19, 2021

Disabling pullapprove because this PR is approved but the fallback group is still pending by accident (the .gitignore does not match to any group).

Loading

alxhub added a commit that referenced this issue Jul 20, 2021
@devversion @alxhub
build: remove unnecessary husky gitignore file (#42870)
6eea132 
We recently updated to Husky v7 through Renovate, but
as of Husky v7, a `.gitignore` file is no longer needed.

This commit removes the file.

PR Close #42870
@alxhub alxhub closed this in 30165f9 Jul 20, 2021
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Aug 20, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Loading

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.