Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong arrow when select Comunity #1433

Open
eamanu opened this issue May 8, 2019 · 6 comments
Open

Wrong arrow when select Comunity #1433

eamanu opened this issue May 8, 2019 · 6 comments

Comments

@eamanu
Copy link
Contributor

@eamanu eamanu commented May 8, 2019

Describe the bug
When click on Community button on the top menu the arrow select Python section

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.python.org/community/
  2. See on the top arrow. Python menu is selected.

Expected behavior
Arrow select Community

Screenshots

image

Desktop (please complete the following information):

  • OS: Debian 9
  • Browser: Firefox
  • Version: 60.6.2esr (64-bit)
@scottilee
Copy link
Contributor

@scottilee scottilee commented Jun 2, 2019

I think the top nav button for "Community" should be removed.

The top nav buttons for "Python" and "PSF" introduce their own sub nav buttons where as the top bar button for "Community" is just same thing as the sub nav button "Community" found under top nav "Python".

@scottilee
Copy link
Contributor

@scottilee scottilee commented Jun 7, 2019

@ewdurbin What do you think? Would this need psf approval? If not I can make a pull request with the change.

@Daniel-Davies
Copy link

@Daniel-Davies Daniel-Davies commented Jul 7, 2020

If this issue is still available I would love to make it my first contribution. Would this be possible?

@eamanu
Copy link
Contributor Author

@eamanu eamanu commented Jul 10, 2020

@Daniel-Davies Go aheah. @scottilee @ewdurbin any decision about Community nav button?

@ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Jul 10, 2020

These menus are configured as part of the django-sitetree module that renders them, so it's not super clear what the code solution would look like.

@Daniel-Davies if you're able to reproduce it locally and give directions on how to resolve it via configuring django-sitetree I can implement the change in Django admin.

@Daniel-Davies
Copy link

@Daniel-Davies Daniel-Davies commented Jul 13, 2020

Ah I see- I won't be much help in that case, but I suppose after playing around with it and reproducing the issue, it looks like the sitetree item for the community tab (alias "shop-meta") has it's "is_current" property set to false, while mistakenly, the Python tab (alias "python-meta") is_current property is set to true.

I hope that's not too generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.