Skip to content

[mypyc] fix build on windows #11316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2021
Merged

[mypyc] fix build on windows #11316

merged 1 commit into from
Oct 12, 2021

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Oct 11, 2021

Trying to fix mypyc/mypy_mypyc-wheels#28,
Don't understand why other windows builds don't complain though...

build\misc_ops.c(515): error C2065: 'ssize_t': undeclared identifier
build\misc_ops.c(515): error C2146: syntax error: missing ';' before identifier 'n'
build\misc_ops.c(515): error C2065: 'n': undeclared identifier
build\misc_ops.c(517): error C2065: 'n': undeclared identifier
build\misc_ops.c(520): error C2065: 'n': undeclared identifier
build\misc_ops.c(521): error C2065: 'n': undeclared identifier

Trying to fix mypyc/mypy_mypyc-wheels#28,
not sure why other windows builds don't complain...

```
build\misc_ops.c(515): error C2065: 'ssize_t': undeclared identifier
build\misc_ops.c(515): error C2146: syntax error: missing ';' before identifier 'n'
build\misc_ops.c(515): error C2065: 'n': undeclared identifier
build\misc_ops.c(517): error C2065: 'n': undeclared identifier
build\misc_ops.c(520): error C2065: 'n': undeclared identifier
build\misc_ops.c(521): error C2065: 'n': undeclared identifier
```
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah, it's weird that mypy CI didn't catch this.

@JukkaL JukkaL merged commit 8b106c1 into python:master Oct 12, 2021
@hauntsaninja hauntsaninja deleted the mypycwin branch October 12, 2021 17:43
ilevkivskyi pushed a commit that referenced this pull request Nov 2, 2021
Trying to fix mypyc/mypy_mypyc-wheels#28,
not sure why other windows builds don't complain...

```
build\misc_ops.c(515): error C2065: 'ssize_t': undeclared identifier
build\misc_ops.c(515): error C2146: syntax error: missing ';' before identifier 'n'
build\misc_ops.c(515): error C2065: 'n': undeclared identifier
build\misc_ops.c(517): error C2065: 'n': undeclared identifier
build\misc_ops.c(520): error C2065: 'n': undeclared identifier
build\misc_ops.c(521): error C2065: 'n': undeclared identifier
```

Co-authored-by: hauntsaninja <>
nehaljwani added a commit to regro-cf-autotick-bot/mypy-feedstock that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants