Do not enable RUBY_DEVEL by RUBY_PATCHLEVEL #4993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremyevans Could you rebase? |
jeremyevans
force-pushed
the
ruby-devel-no-auto-17468
branch
from
fd215d1 to
c22f880
Compare
|
@nobu I rebased against the current master branch. |
ko1
reviewed
Nov 8, 2021
vm_debug.h
Outdated
| #if RUBY_DEVEL | ||
| #ifndef USE_RUBY_DEBUG_LOG | ||
| #define USE_RUBY_DEBUG_LOG 0 | ||
| #define USE_RUBY_DEBUG_LOG 1 |
There was a problem hiding this comment.
USE_RUBY_DEBUG_LOG introduces a few performance penalty so it should be off by default even if RUBY_DEVEL is defined, IMO.
There was a problem hiding this comment.
OK, I'll make that change.
This makes RUBY_DEVEL not enabled automatically. It still can be enabled manually. Test manually using RUBY_DEVEL in CI. Implements [Feature #17468]
jeremyevans
force-pushed
the
ruby-devel-no-auto-17468
branch
from
7f66cd2 to
e8b22aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes RUBY_DEVEL not enabled automatically. It still can be
enabled manually. If enabled manually, it defines USE_RUBY_DEBUG_LOG
to 1 if not defined.
Implements [Feature #17468]