Skip to content

/ NativeScript Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): TypeScript 4 + cleanup #8967

Merged
merged 4 commits into from Oct 19, 2020
Merged

feat(core): TypeScript 4 + cleanup #8967

merged 4 commits into from Oct 19, 2020

Conversation

@NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Oct 17, 2020

  • TypeScript 4.x
  • Updates workspace to Nx 10.3.x
  • Adds various graphics from old repo which were used in e2e ui testing app fixing previously failing test pages
  • all tests passing
  • removed unused core-compat
  • fixes core build to ensure TypeScript errors output to console if encountered rather than swallowed
@cla-bot cla-bot bot added the cla: yes label Oct 17, 2020
@NathanWalker NathanWalker requested a review from rigor789 Oct 17, 2020
rigor789
rigor789 reviewed Oct 17, 2020
View changes
packages/core/application/index.ios.ts Outdated Show resolved Hide resolved
packages/core/application/index.android.ts Outdated Show resolved Hide resolved
packages/core/image-asset/index.android.ts Show resolved Hide resolved
packages/core/ui/proxy-view-container/index.ts Show resolved Hide resolved
@NathanWalker NathanWalker force-pushed the feat/typescript-4-and-cleanup branch from 7d58821 to f4da8b1 Oct 17, 2020
@NathanWalker
feat(core): TypeScript 4 + cleanup
be389d9
@NathanWalker
chore: cleanup
4c6eb50
@NathanWalker
chore: use const
bf70d05
@NathanWalker
chore: cleanup
8125127
@NathanWalker NathanWalker force-pushed the feat/typescript-4-and-cleanup branch from c040b83 to 8125127 Oct 19, 2020
@NathanWalker NathanWalker merged commit 2243660 into master Oct 19, 2020
2 of 4 checks passed
@NathanWalker NathanWalker deleted the feat/typescript-4-and-cleanup branch Oct 19, 2020
crowmagnumb added a commit to animalus/NativeScript that referenced this issue Oct 23, 2020
@NathanWalker @crowmagnumb
feat(core): TypeScript 4 + cleanup (NativeScript#8967)
0c3e016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@NathanWalker @rigor789