-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-44092: Don't reset statements/cursors before rollback #26026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In SQLite versions pre 3.7.11, pending statements would block a rollback. This is no longer the case, so remove the workaround.
Tests taken from issue 33376 |
@corona10 This change means that UPDATE: see msg393944 |
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit f7065b1 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
@serhiy-storchaka, I'm not sure how to proceed in order to land this. I'm pretty sure this is correct; it works across all supported SQLite versions. I've tried to ping Berker about this, but I haven't gotten any response. Proposal: We merge this to See the bpo issue for my notes about this fix. |
@animalize: would you mind reviewing this? |
I will try, I'm not a deep user of SQL, but if you can't find a reviewer I'm glad to try, hope I can review this in 2~4 weeks. |
Great, thanks. You'll find my reasoning in the bpo. |
@ghaering: Would you mind reviewing this? (A 👎🏻 or 👍🏻 reaction would be 👌🏻). Totally understand if you won't. |
It seems |
Thanks for helping out, @animalize! |
@pablogsal, it would have been nice to get this into the upcoming alpha :) |
It seems this PR can be committed. Then to do subsequent improvement. |
Thank you, Pablo! 🙏🏻 |
In SQLite versions pre 3.7.11, pending statements would block a
rollback. We now require SQLite 3.7.15, so this workaround can go.
https://bugs.python.org/issue44092