Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-44849: Fix os.set_inheritable() on FreeBSD 14 with O_PATH (GH-27623) #28978

Merged
merged 1 commit into from Oct 19, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 15, 2021

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue44849

…GH-27623)

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Oct 15, 2021

@vstinner: Status check is done, and it's a success .

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 15, 2021

The AMD64 FreeBSD Shared 3.8 buildbot is still up and running, but test_os.test_get_set_inheritable_o_path() fails:
https://buildbot.python.org/all/#/builders/555/builds/51

I propose to backport my fix to report the Python 3.8 FreeBSD buildbot.

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 15, 2021

cc @ambv

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Oct 15, 2021

@vstinner: Status check is done, and it's a success .

@ambv ambv merged commit 67e10be into python:3.8 Oct 19, 2021
13 checks passed
@miss-islington miss-islington deleted the backport-c24896c-3.8 branch Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants