tkinter.ttk.Treeview: add Literal[""] to item options #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

srittau merged 1 commit into python:master from Akuli:literal

Oct 16, 2021

Collaborator

Akuli commented Oct 16, 2021

Fixes #6177. The empty list is same as the empty string in Tcl, and sometimes tkinter returns empty strings to denote empty sequences:

>>> import tkinter.ttk
>>> tv = tkinter.ttk.Treeview()
>>> tv.item("")
{'text': '', 'image': '', 'values': '', 'open': 0, 'tags': ''}

Conflicts with #6181. I think it's easier to merge this first.


          tkinter.ttk.Treeview: more Literal[""]

1c18974

Contributor

github-actions bot commented Oct 16, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau approved these changes

View reviewed changes

srittau merged commit 5b03ad1 into python:master

Akuli deleted the literal branch

November 26, 2021 23:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet