AbstractEventLoop.run_in_executor() returns Future not just Awaitable #6187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.python.org/3.10/library/asyncio-eventloop.html#asyncio.loop.run_in_executor > This method returns a asyncio.Future object.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
altendky
added a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Oct 22, 2021
mariano54
pushed a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Oct 26, 2021
* add WalletWeightProofHandler._executor_shutdown_tempfile This is a minimally intrusive change to trigger the long-running wallet weight proof handler's executors to terminate when requested. * add more cancellation for wallet weight proof handler * remove a few addressed TODO comments * simplify validate weight proof task cancellation * hints for .run_in_executor() returning asyncio.Future python/typeshed#6187
Quexington
pushed a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Nov 4, 2021
* add WalletWeightProofHandler._executor_shutdown_tempfile This is a minimally intrusive change to trigger the long-running wallet weight proof handler's executors to terminate when requested. * add more cancellation for wallet weight proof handler * remove a few addressed TODO comments * simplify validate weight proof task cancellation * hints for .run_in_executor() returning asyncio.Future python/typeshed#6187
Quexington
pushed a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Nov 8, 2021
* add WalletWeightProofHandler._executor_shutdown_tempfile This is a minimally intrusive change to trigger the long-running wallet weight proof handler's executors to terminate when requested. * add more cancellation for wallet weight proof handler * remove a few addressed TODO comments * simplify validate weight proof task cancellation * hints for .run_in_executor() returning asyncio.Future python/typeshed#6187
Quexington
pushed a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Nov 8, 2021
* add WalletWeightProofHandler._executor_shutdown_tempfile This is a minimally intrusive change to trigger the long-running wallet weight proof handler's executors to terminate when requested. * add more cancellation for wallet weight proof handler * remove a few addressed TODO comments * simplify validate weight proof task cancellation * hints for .run_in_executor() returning asyncio.Future python/typeshed#6187
Quexington
pushed a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Nov 16, 2021
* add WalletWeightProofHandler._executor_shutdown_tempfile This is a minimally intrusive change to trigger the long-running wallet weight proof handler's executors to terminate when requested. * add more cancellation for wallet weight proof handler * remove a few addressed TODO comments * simplify validate weight proof task cancellation * hints for .run_in_executor() returning asyncio.Future python/typeshed#6187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/3.10/library/asyncio-eventloop.html#asyncio.loop.run_in_executor