Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymSGD Excessively Verbose #5598

Open
justinormont opened this issue Jan 25, 2021 · 9 comments
Open

SymSGD Excessively Verbose #5598

justinormont opened this issue Jan 25, 2021 · 9 comments

Comments

@justinormont
Copy link
Contributor

@justinormont justinormont commented Jan 25, 2021

Remove logging line, or modify from ch.Info to ch.Trace:

ch.Info($"Bias: {bias}, Weights: [{String.Join(",", weights.DenseValues())}]");

For my text dataset, this logging line dumps ~100 pages of floats to my console. That level of verbosity is unneeded at the Info level.

I'd recommend just removing the logging line.

@rohittrimalle
Copy link

@rohittrimalle rohittrimalle commented Aug 17, 2021

Can I solve this issue?

@bhargavsonagara
Copy link

@bhargavsonagara bhargavsonagara commented Aug 19, 2021

hiii, I am new to it plz guide me where to start and what to do!

@michaelgsharp
Copy link
Member

@michaelgsharp michaelgsharp commented Aug 23, 2021

@rohittrimalle or @bhargavsonagara, feel free to tackle this issue if you would like.

You will have to remove the line @justinormont says, but then you will also have to fix the SymSGD baseline test files. We can help walk you through that when you get to that point if you want.

@bhargavsonagara
Copy link

@bhargavsonagara bhargavsonagara commented Aug 24, 2021

@rohittrimalle or @bhargavsonagara, feel free to tackle this issue if you would like.

You will have to remove the line @justinormont says, but then you will also have to fix the SymSGD baseline test files. We can help walk you through that when you get to that point if you want.

I have to modify all the pages from ch.Info to ch.Trace right?
SymSGD baseline test files means
plz help

@michaelgsharp
Copy link
Member

@michaelgsharp michaelgsharp commented Aug 25, 2021

You don't need to modify all the lines, just the once place mentioned in the issue,

ch.Info($"Bias: {bias}, Weights: [{String.Join(",", weights.DenseValues())}]");
.

If you navigate to reporoot/test/BaselineOutput/Common you will see a bunch of folder with files. Once you remove the ch.Info line, some of the tests will fail saying the baseline doesn't match. What you need to do, is find the file mentioned in the test failure (it will be in that folder I mentioned), and update it with the new version. The test will actually write the new version to a file in the artifacts folder somewhere, but I can't remember exactly where off of the top of my head. If you are unable to find it after you have run the tests let me know and I will find it.

Does that help?

@bhargavsonagara
Copy link

@bhargavsonagara bhargavsonagara commented Aug 26, 2021

You don't need to modify all the lines, just the once place mentioned in the issue,

ch.Info($"Bias: {bias}, Weights: [{String.Join(",", weights.DenseValues())}]");

.
If you navigate to reporoot/test/BaselineOutput/Common you will see a bunch of folder with files. Once you remove the ch.Info line, some of the tests will fail saying the baseline doesn't match. What you need to do, is find the file mentioned in the test failure (it will be in that folder I mentioned), and update it with the new version. The test will actually write the new version to a file in the artifacts folder somewhere, but I can't remember exactly where off of the top of my head. If you are unable to find it after you have run the tests let me know and I will find it.

Does that help?

Yes, it's help too much but I am unable to find them
there is an error like:
##[error]XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: D:\a\1\s\artifacts\TestResults\Debug\Microsoft.ML.Predictor.Tests_netcoreapp2.1_x64.html [netcoreapp2.1|x64]

So how I resolve this error. you just help me to solve one error other I will solve by myself.

@bhargavsonagara
Copy link

@bhargavsonagara bhargavsonagara commented Aug 26, 2021

@michaelgsharp I am unable to find Microsoft.ML.Predictor.Tests_netcoreapp2.1_x64.html this as it mention in the error.

Just imagine if I find that so I have to change the version 2.1_x64.html to 3.1_x64.html version right?
pls help me SIR.

And I checked in reporoot/test/BaselineOutput/Common their is no any artifacts.

@ankitasankars
Copy link

@ankitasankars ankitasankars commented Aug 29, 2021

Hello, Can I use this issue as my first contribution? I'm new so please can someone guide me?

@bhargavsonagara
Copy link

@bhargavsonagara bhargavsonagara commented Aug 29, 2021

Hello, Can I use this issue as my first contribution? I'm new so please can someone guide me?

You will have to remove the line @justinormont says, but then you will also have to fix the SymSGD baseline test files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants