Skip to content

Move some distributed C++ GTest unit tests from test.sh to Python wrapper #64252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move some distributed C++ GTest unit tests from test.sh to Python wrapper #64252

wants to merge 1 commit into from

Conversation

haovic
Copy link

@haovic haovic commented Aug 31, 2021

Summary:
This is the beginning of transitioning away from test.sh: #64067

Moved execution of FileStoreTest, HashStoreTest, TCPStoreTest from test.sh to run_test.py. Since these are compiled tests, the logic of test.sh was just migrated and the tests are run through subprocess.

Test Plan:

python3 test/run_test.py --include cpp/c10d/FileStoreTest cpp/c10d/HashStoreTest cpp/c10d/TCPStoreTest

Wait for CI

Differential Revision: D30662844

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 31, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 5ddf794 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30662844

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30662844

@haovic haovic linked an issue Aug 31, 2021 that may be closed by this pull request
Execute C++ based GTest unit tests from a python wrapper #64067
Open
@haovic haovic requested review from zhouzhuojie and malfet August 31, 2021 23:22
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30662844

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30662844

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30662844

@codecov
Copy link

codecov bot commented Sep 1, 2021 •
edited
Loading

Codecov Report

Merging #64252 (5ddf794) into master (1553259) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #64252      +/-   ##
==========================================
+ Coverage   66.62%   66.70%   +0.08%     
==========================================
  Files         710      710              
  Lines       92433    92433              
==========================================
+ Hits        61583    61657      +74     
+ Misses      30850    30776      -74

@haovic haovic added the with-ssh label Sep 2, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30662844

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30662844

malfet
malfet reviewed Sep 8, 2021
View reviewed changes
malfet
malfet reviewed Sep 8, 2021
View reviewed changes
malfet
malfet reviewed Sep 8, 2021
View reviewed changes
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30662844

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30662844

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30662844

@haovic @facebook-github-bot
Move some distributed C++ GTest unit tests from test.sh to Python wra…
5ddf794 
…pper (pytorch#64252)

Summary:
Pull Request resolved: pytorch#64252

This is the beginning of transitioning away from test.sh: pytorch#64067

Moved execution of FileStoreTest, HashStoreTest, TCPStoreTest from test.sh to run_test.py. Since these are compiled tests, the logic of test.sh was just migrated and the tests are run through subprocess.

Test Plan:
```
python3 test/run_test.py --include cpp/c10d/FileStoreTest cpp/c10d/HashStoreTest cpp/c10d/TCPStoreTest
```

Wait for CI

Differential Revision: D30662844

fbshipit-source-id: 3807399df05a0f5a08e06f11eba68f602b2bf014
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30662844

@haovic haovic closed this Sep 21, 2021
@haovic haovic deleted the export-D30662844 branch September 21, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet left review comments

@zhouzhuojie zhouzhuojie Awaiting requested review from zhouzhuojie

Assignees
No one assigned
Labels
cla signed fb-exported with-ssh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Execute C++ based GTest unit tests from a python wrapper
3 participants
@haovic @facebook-github-bot @malfet