Wavelet tree #4267
Wavelet tree #4267
Conversation
![algorithms-keeper[bot]](https://web.archive.org/web/20211026020554im_/https://avatars.githubusercontent.com/in/86183?s=60&v=4){kind=small}
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| class Node: | ||
| def __init__(self, n): |
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
| self.left: Optional[Node] = None | ||
| self.right: Optional[Node] = None | ||
|
|
||
| def __repr__(self): |
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function __repr__
Please provide return type hint for the function: __repr__. If the function does not return a value, please provide the type hint as: def function() -> None:
| return root | ||
|
|
||
|
|
||
| def rank_from_start(node: Node, num: int, i: int) -> int: |
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function rank_from_start
Please provide descriptive name for the parameter: i
| return rank_from_start(node.right, num, i - node.map_left[i]) | ||
|
|
||
|
|
||
| def rank(node: Node, num: int, i: int, j: int) -> int: |
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function rank
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
| return rank_till_j - rank_before_i | ||
|
|
||
|
|
||
| def quantile(node: Node, k: int, i: int, j: int) -> int: |
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function quantile
Please provide descriptive name for the parameter: k
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
| ) | ||
|
|
||
|
|
||
| def range_counting(node: Node, i: int, j: int, x: int, y: int) -> int: |
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function range_counting
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
| return left + right | ||
|
|
||
|
|
||
| def main(): |
Please provide return type hint for the function: main. If the function does not return a value, please provide the type hint as: def function() -> None:
…nto wavelet_tree Maintain consistency between the local and remote branch
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| class Node: | ||
| def __init__(self, length): |
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: length
| self.left: Optional[Node] = None | ||
| self.right: Optional[Node] = None | ||
|
|
||
| def __repr__(self): |
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function __repr__
Please provide return type hint for the function: __repr__. If the function does not return a value, please provide the type hint as: def function() -> None:
| return root | ||
|
|
||
|
|
||
| def rank_from_start(node: Node, num: int, index: int) -> int: |
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function rank_from_start
| return rank_till_end - rank_before_start | ||
|
|
||
|
|
||
| def quantile(node: Node, k: int, start: int, end: int) -> int: |
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function quantile
Please provide descriptive name for the parameter: k
| ) | ||
|
|
||
|
|
||
| def range_counting(node: Node, start: int, end: int, x: int, y: int) -> int: |
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function range_counting
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| return root | ||
|
|
||
|
|
||
| def rank_from_start(node: Node, num: int, index: int) -> int: |
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function rank_from_start
Add doctests to placate the algorithm-bot, thanks to @cclauss. Co-authored-by: Christian Clauss <cclauss@me.com>
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| return root | ||
|
|
||
|
|
||
| def rank_from_start(node: Node, num: int, index: int) -> int: |
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/wavelet_tree.py, please provide doctest for the function rank_from_start
|
Let's get a review from @dhruvmanila first... |
|
Thanks for the heads up! I will take a look at it today. |
|
Just following up for any updates on this. |
|
Just following up for any updates. |
|
@cclauss @dhruvmanila just following up for any updates on this PR. |
|
Close and reopen to rebase… |
* Added the matrix_exponentiation.py file in maths directory * Implemented the requested changes * Update matrix_exponentiation.py * resolve merge conflict with upstream branch * add new line at end of file * add wavelet_tree * fix isort issue * updating DIRECTORY.md * fix variable names in wavelet_tree and correct typo * Add type hints and variable renaming * Update data_structures/binary_tree/wavelet_tree.py Add doctests to placate the algorithm-bot, thanks to @cclauss. Co-authored-by: Christian Clauss <cclauss@me.com> * Move doctest to individual functions and reformat code * Move common test array to the global scope and reuse in tests * MMove test array to global scope and minor linting changes * Correct the failing pytest tests * MUse built-in list for type annotation * Update wavelet_tree.py * types-requests * updating DIRECTORY.md * Update wavelet_tree.py * # type: ignore * # type: ignore * Update decrypt_caesar_with_chi_squared.py * , * Update decrypt_caesar_with_chi_squared.py Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: Aniruddha Bhattacharjee <aniruddha@Aniruddhas-MacBook-Air.local>
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.The text was updated successfully, but these errors were encountered: