Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: change tabindex on login to skip email login link #14732

Merged
merged 1 commit into from Oct 27, 2021
Merged

Conversation

@awesomerobot
Copy link
Member

@awesomerobot awesomerobot commented Oct 26, 2021

Some discussion here: https://meta.discourse.org/t/tab-at-login-styling/183425/

This changes the tabindex of elements so the "Skip the password; email me a login link" link that shows under the username input doesn't interrupt the username -> password tab order that keyboard users and autofill extensions have come to expect.

Visually the "Skip the password; email me a login link" under the username input is the "right place, right time" for users that aren't navigating with their keyboard... so using tabindex is a compromise.

CvX
CvX approved these changes Oct 26, 2021
@awesomerobot awesomerobot merged commit 6aa6275 into main Oct 27, 2021
10 of 11 checks passed
@awesomerobot awesomerobot deleted the login-tabindex branch Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants