Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Optimal Merge Pattern Algorithm #5274

Merged
merged 2 commits into from Oct 14, 2021
Merged

Added Optimal Merge Pattern Algorithm #5274

merged 2 commits into from Oct 14, 2021

Conversation

Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement optimal merge pattern
2 participants
@Raj-Pansuriya @cclauss
@Raj-Pansuriya
Copy link
Contributor

@Raj-Pansuriya Raj-Pansuriya commented Oct 13, 2021 •
edited

Added a new algorithm Optimal Merge Pattern which returns the optimal cost of mergeing a series of files having different sizes. Follows Greedy Method

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #5076 .
@Raj-Pansuriya
Minor changes due to precommit
6ed4c27
@Raj-Pansuriya Raj-Pansuriya changed the title Minor changes due to precommit Added Optimal Merge Pattern Algorithm Oct 13, 2021
@cclauss
Update optimal_merge_pattern.py
2935f45
cclauss
cclauss approved these changes Oct 14, 2021
View changes
Copy link
Member

@cclauss cclauss left a comment

LGTM

@cclauss cclauss merged commit 943e03f into TheAlgorithms:master Oct 14, 2021
2 checks passed
shermanhui added a commit to shermanhui/Python that referenced this issue Oct 22, 2021
@Raj-Pansuriya @cclauss @shermanhui
Added Optimal Merge Pattern Algorithm (TheAlgorithms#5274)
42e9f2b 
* Minor changes due to precommit

* Update optimal_merge_pattern.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment