Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimised Cypher queries in Neo4j example #25973

Merged
merged 10 commits into from Jul 19, 2021
Merged

Optimised Cypher queries in Neo4j example #25973

merged 10 commits into from Jul 19, 2021

Conversation

adam-cowley
Copy link
Contributor

Thank you for including a Neo4j example!

This PR rewrites the Cypher queries using a pattern comprehension which will make them more performant and removes the need for the collect(DISTINCT ...) step.

@ijjk ijjk added the area: examples Anything inside the examples folder label Jun 10, 2021
leerob
leerob reviewed Jun 17, 2021
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after that!

@adam-cowley
Copy link
Contributor Author

I realised a mistake with how the numbers were handled in the front end. There is a gotcha when it comes to JavaScript integers and Neo4j (Java) integers.

Using disableLosslessIntegers with instantiating the driver solves the problem in this use case. In 90% of cases, this workaround will be fine, if the integer happens to be a BigInteger in this case then the number is converted to a string. Either way it'll be handled the same way by the UI.

@adam-cowley adam-cowley requested a review from leerob July 5, 2021 13:48
leerob
leerob previously approved these changes Jul 5, 2021
View reviewed changes
@kodiakhq kodiakhq bot requested review from huozhi, padmaia and styfle as code owners July 5, 2021 17:40
ijjk
ijjk approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit 9774d9b into vercel:canary Jul 19, 2021
22 checks passed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@adam-cowley
Optimised Cypher queries in Neo4j example (vercel#25973)
8e759e1 
Thank you for including a Neo4j example!

This PR rewrites the Cypher queries using a [pattern comprehension](https://neo4j.com/docs/cypher-manual/current/syntax/lists/#cypher-pattern-comprehension) which will make them more performant and removes the need for the `collect(DISTINCT ...)` step.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes ijjk is a code owner

@leerob leerob leerob left review comments

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
area: examples Anything inside the examples folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adam-cowley @leerob @ijjk