Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Financial: principle -> principal #5614

Merged
merged 2 commits into from Oct 26, 2021
Merged

Financial: principle -> principal #5614

merged 2 commits into from Oct 26, 2021

Conversation

Reviewers

@poyea poyea

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cclauss @poyea
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 26, 2021

Describe your change:

@tarcisiobruni

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
cclauss and others added 2 commits Oct 26, 2021
@cclauss
Financial: principle -> principal
8f19059 
The originally invested amount of money: `principal`
-- https://www.grammarly.com/blog/principle-principal/
updating DIRECTORY.md
9f3668b
@cclauss cclauss requested a review from poyea Oct 26, 2021
poyea
poyea approved these changes Oct 26, 2021
View changes
@cclauss cclauss mentioned this pull request Oct 26, 2021
Merged
14 tasks
@poyea poyea merged commit cb4dc19 into master Oct 26, 2021
3 checks passed
@poyea poyea deleted the Financial-principle-->principal branch Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment