Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: close accepted connection #48753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

net/http: close accepted connection #48753

wants to merge 1 commit into from
+40 −9

Conversation

@AlexanderYastrebov
Copy link
Contributor

@AlexanderYastrebov AlexanderYastrebov commented Oct 3, 2021

Fixes #48642
@google-cla google-cla bot added the cla: yes label Oct 3, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 3, 2021

This PR (HEAD: 2b23f0f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/353714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2021

Message from Damien Neil:

Patch Set 1: Run-TryBot+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2021

Message from Damien Neil:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2021

This PR (HEAD: 27db2ba) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/353714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2021

Message from Alexander Yastrebov:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 8, 2021

Message from Damien Neil:

Patch Set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 8, 2021

Message from Damien Neil:

Patch Set 3: Run-TryBot+1 Code-Review+2 Trust+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 8, 2021

Message from Go Bot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 11, 2021

Message from Alexander Yastrebov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 17, 2021

Message from Alexander Yastrebov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 17, 2021

Message from Alexander Yastrebov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 18, 2021

Message from Cherry Mui:

Patch Set 4: Run-TryBot+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 18, 2021

Message from Go Bot:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 18, 2021

Message from Go Bot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 18, 2021

Message from Go Bot:

Patch Set 4: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/353714.
After addressing review feedback, remember to publish your drafts!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

net/http: Server.Close may not able to close all connections
2 participants
@AlexanderYastrebov @gopherbot