bpo-45629: Add a test for the "freeze" tool. #29222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
ericsnowcurrently
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
ericsnowcurrently
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
|
@gpshead you may notice that I'm doing an out-of-tree build. |
ericsnowcurrently
changed the title
ericsnowcurrently
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
gpshead
added a commit
to gpshead/cpython
that referenced
this issue
Feb 3, 2022
It was added as part of python#29222 to avoid running freeze tool tests on the buildbots but the logic was wrong so it did not skip tests on typical posix setup buildbots where the worker is launched from cron via an @reboot task and thus have no USER environment variable. This uses the canonical `getpass.getuser()` API rather than rolling its own attempt.
gpshead
added a commit
that referenced
this issue
Feb 3, 2022
It was added as part of #29222 to avoid running freeze tool tests on the buildbots but the logic was wrong so it did not skip tests on typical posix setup buildbots where the worker is launched from cron via an @reboot task and thus have no USER environment variable. This uses the canonical `getpass.getuser()` API rather than rolling its own attempt.
erlend-aasland
pushed a commit
to erlend-aasland/cpython
that referenced
this issue
Feb 11, 2022
It was added as part of python#29222 to avoid running freeze tool tests on the buildbots but the logic was wrong so it did not skip tests on typical posix setup buildbots where the worker is launched from cron via an @reboot task and thus have no USER environment variable. This uses the canonical `getpass.getuser()` API rather than rolling its own attempt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The "freeze" tool has been part of the repo for a long time. However, it hasn't had any tests in the test suite to guard against regressions. We add such a test here. This is especially important as there has been a lot of change recently related to frozen modules, with more to come.
Note that as part of the test we build Python out-of-tree and install it in a temp dir.
https://bugs.python.org/issue45629